From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Dai, Wei" <wei.dai@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload supported
Date: Fri, 11 May 2018 15:36:24 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C24E0CA496@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <DB7PR05MB442632DC51BC1B8C308F27AAC3980@DB7PR05MB4426.eurprd05.prod.outlook.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Thursday, May 10, 2018 5:39 AM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload
> supported
>
> Thursday, May 10, 2018 1:09 AM, Ferruh Yigit:
> > Subject: [PATCH] app/testpmd: check if CRC strip offload supported
> >
> > Testpmd set CRC_STRIP offload blindly, this is wrong according offload
> > API definition, and will cause error for the PMDs that doesn't support
> > CRC_STRIP like virtual PMDs.
> >
> > Check if underlying device report this capability and don't set it if
> > not supported.
> >
> > Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API")
> > Cc: shahafs@mellanox.com
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Yes this is the correct behavior. I hope all the PMDs report the CRC strip
> correctly.
>
> Acked-by: Shahaf Shuler < shahafs@mellanox.com>
Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com>
next prev parent reply other threads:[~2018-05-11 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 22:09 Ferruh Yigit
2018-05-10 4:39 ` Shahaf Shuler
2018-05-11 15:36 ` Iremonger, Bernard [this message]
2018-05-11 16:27 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C24E0CA496@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=shahafs@mellanox.com \
--cc=wei.dai@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).