From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 6786F1C782 for ; Fri, 11 May 2018 17:36:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 May 2018 08:36:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,389,1520924400"; d="scan'208";a="38575103" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga007.fm.intel.com with ESMTP; 11 May 2018 08:36:26 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX102.ger.corp.intel.com ([169.254.2.83]) with mapi id 14.03.0319.002; Fri, 11 May 2018 16:36:25 +0100 From: "Iremonger, Bernard" To: Shahaf Shuler , "Yigit, Ferruh" , "Lu, Wenzhuo" , "Wu, Jingjing" CC: "dev@dpdk.org" , "Dai, Wei" , "Zhang, Qi Z" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload supported Thread-Index: AQHT6BjrqwwBe6IqlUyAj0omg7Icq6QqqtvA Date: Fri, 11 May 2018 15:36:24 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C24E0CA496@IRSMSX108.ger.corp.intel.com> References: <20180509220904.128983-1-ferruh.yigit@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTg1MzA5YzgtNDZmZS00MjgyLWE3NjItYzIwZjEwZDI3MTUzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMDFyallDaHFVTnJkT25lYWNFWldLMjJzRGxUNWJVbDN2YjRXczN6UlpRYVVPNkdkTXAzaUd0RkRZMUJpZU1DYyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload supported X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 15:36:30 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Thursday, May 10, 2018 5:39 AM > To: Yigit, Ferruh ; Lu, Wenzhuo > ; Wu, Jingjing > Cc: dev@dpdk.org; Dai, Wei ; Zhang, Qi Z > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: check if CRC strip offload > supported >=20 > Thursday, May 10, 2018 1:09 AM, Ferruh Yigit: > > Subject: [PATCH] app/testpmd: check if CRC strip offload supported > > > > Testpmd set CRC_STRIP offload blindly, this is wrong according offload > > API definition, and will cause error for the PMDs that doesn't support > > CRC_STRIP like virtual PMDs. > > > > Check if underlying device report this capability and don't set it if > > not supported. > > > > Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API") > > Cc: shahafs@mellanox.com > > > > Signed-off-by: Ferruh Yigit >=20 > Yes this is the correct behavior. I hope all the PMDs report the CRC stri= p > correctly. >=20 > Acked-by: Shahaf Shuler < shahafs@mellanox.com> Acked-by: Bernard Iremonger