From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
Matan Azrad <matan@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix slave port detection
Date: Fri, 11 May 2018 16:09:43 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C24E0CA4F4@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <2044227.RGsR745gvM@xps>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Sunday, April 22, 2018 11:58 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: stable@dpdk.org; Matan Azrad <matan@mellanox.com>; dev@dpdk.org;
> Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix slave port
> detection
>
> Wenzhuo, Declan,
> Any comment or ack, please?
>
> 28/03/2018 13:17, Matan Azrad:
> > Testpmd allows to create and control bonding devices by run time
> > command lines using the bonding PMD API.
> >
> > Some bonding device slaves operations(close, stop, etc) should not be
> > used by the application and must be managed by the bonding PMD.
> >
> > Thus, Testpmd manages slave flags to prevent the special operations
> > calls and when a slave is added to bonding device by a run time
> > command line, the flag is set.
> >
> > There is one more way to define the slaves for a bonding device using
> > EAL command line and Testpmd doesn't set the slave flag in this case
> > what causes to the special operations to be called by Testpmd.
> >
> > Add one more check to detect bonding slave device.
> >
> > Fixes: 41b05095c4d1 ("app/testpmd: fix bonding start")
> > Fixes: 0e545d3047fe ("app/testpmd: check stopping port is not in
> > bonding")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com>
next prev parent reply other threads:[~2018-05-11 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 11:17 [dpdk-dev] " Matan Azrad
2018-04-22 22:58 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-05-11 16:09 ` Iremonger, Bernard [this message]
2018-05-14 2:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C24E0CA4F4@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).