From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B3DF81C75B for ; Mon, 14 May 2018 12:35:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 May 2018 03:35:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,399,1520924400"; d="scan'208";a="224047843" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga005.jf.intel.com with ESMTP; 14 May 2018 03:35:18 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX154.ger.corp.intel.com ([169.254.12.181]) with mapi id 14.03.0319.002; Mon, 14 May 2018 11:35:17 +0100 From: "Iremonger, Bernard" To: "Awal, Mohammad Abdul" , "dev@dpdk.org" , "adrien.mazarguil@6wind.com" CC: "Iremonger, Bernard" Thread-Topic: [PATCH v2 2/2] doc/guides: updated testpmd app user guide for vxlan/nvgre encap/decap Thread-Index: AQHT6Ut6spyUScj/SUaR1tgRvrKwzKQvCCXQ Date: Mon, 14 May 2018 10:35:17 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C24E0CC237@IRSMSX108.ger.corp.intel.com> References: <1526058841-31650-1-git-send-email-mohammad.abdul.awal@intel.com> <1526058841-31650-3-git-send-email-mohammad.abdul.awal@intel.com> In-Reply-To: <1526058841-31650-3-git-send-email-mohammad.abdul.awal@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjdhNWFlOTktZWIwOC00ODIyLTg0OGQtYTBjNDZmNTBiZjFiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoielpYTUcxclZrUnBlVnFSQldQbTB3N2xVMXdmOHZSd0Nna1dxRG8ySzVNNElydE5uTlE2MW5PZkh5Q2k5d1hzSyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/2] doc/guides: updated testpmd app user guide for vxlan/nvgre encap/decap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 10:35:21 -0000 Hi Awal, > -----Original Message----- > From: Awal, Mohammad Abdul > Sent: Friday, May 11, 2018 6:14 PM > To: dev@dpdk.org; Iremonger, Bernard ; > adrien.mazarguil@6wind.com > Subject: [PATCH v2 2/2] doc/guides: updated testpmd app user guide for > vxlan/nvgre encap/decap >=20 > Updated the testpmd user guide documentation with how to used new action Typo, "used" in line above should be "use". > types RTE_FLOW_ACTION_VXLAN_ENCAP, RTE_FLOW_ACTION_VXLAN_DECAP, > RTE_FLOW_ACTION_NVGRE_ENCAP, RTE_FLOW_ACTION_NVGRE_DECAP > capabilities. >=20 > Signed-off-by: Mohammad Abdul Awal > --- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 50 > +++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) >=20 > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index 542c217..6ee3ff3 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -3559,6 +3559,56 @@ This section lists supported actions and their > attributes, if any. >=20 > - ``ethertype``: Ethertype. >=20 > +- ``vxlan_encap``: encapsulate the inner flow with pattern of headers > + according to RFC7348. > + > + - ``eth_dst {MAC-48}``: outer ether destination. > + > + - ``eth_src {MAC-48}``: outer ether source. > + > + - ``eth_type {unsigned}``: outer ether type. > + > + - ``vlan_tci {unsigned}``: outer vlan tci. > + > + - ``ipv4_dst {ipv4 address}``: outer ipv4 destination. > + > + - ``ipv4_src {ipv4 address}``: outer ipv4 source. > + > + - ``ipv4_proto {unsigned}``: outer ipv4 proto. > + > + - ``udp_dst {unsigned}``: outer udp destination. > + > + - ``udp_src {unsigned}``: outer udp source. > + > + - ``vxlan_vni {unsigned}``: outer vxlan vni. > + > + - ``end``: outer vxlan header pattern end. > + > +- ``vxlan_decap``: decapsulate the vxlan tunnel flow according to RFC734= 8. > + > +- ``nvgre_encap``: encapsulate the inner flow with pattern of headers > + according to RFC7637. > + > + - ``eth_dst {MAC-48}``: outer ether destination. > + > + - ``eth_src {MAC-48}``: outer ether source. > + > + - ``eth_type {unsigned}``: outer ether type. > + > + - ``vlan_tci {unsigned}``: outer vlan tci. > + > + - ``ipv4_dst {ipv4 address}``: outer ipv4 destination. > + > + - ``ipv4_src {ipv4 address}``: outer ipv4 source. > + > + - ``ipv4_proto {unsigned}``: outer ipv4 proto. > + > + - ``nvgre_vsni {unsigned}``: outer nvgre vsni. > + > + - ``end``: outer nvgre header pattern end. > + > +- ``nvgre_decap``: decapsulate the nvgre tunnel flow according to RFC763= 7. > + > Destroying flow rules > ~~~~~~~~~~~~~~~~~~~~~ I see that section 4.14.1 has been updated to document the syntax of the en= cap and decap actions, which look fine.=20 However my comment on the v1 patch about adding some sample encap and decap= rules has not been addressed. My understanding is, that it is a two stage process where the tunnel endpoi= nt flow is created first and the encapsulated flow is then created, this is= not obvious from the syntax description section. I think it would be useful to add some sample flows after section 4.12.8 >=20 > -- > 2.7.4