From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 87323EE2D for ; Wed, 16 May 2018 17:06:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2018 08:06:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,406,1520924400"; d="scan'208";a="224731970" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga005.jf.intel.com with ESMTP; 16 May 2018 08:06:41 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX101.ger.corp.intel.com ([169.254.1.118]) with mapi id 14.03.0319.002; Wed, 16 May 2018 16:03:21 +0100 From: "Iremonger, Bernard" To: Wisam Jaddo , "Wu, Jingjing" , "Lu, Wenzhuo" , "thomas@monjalon.net" CC: "rasland@mellanox.com" , "dev@dpdk.org" , "shahafs@mellanox.com" Thread-Topic: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add set topology on the fly command Thread-Index: AQHT55SCxEjL2ixlt0WMoT9sx56TOaQyfr9A Date: Wed, 16 May 2018 15:03:21 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C24E0CD4DD@IRSMSX108.ger.corp.intel.com> References: <1525870039-11261-1-git-send-email-wisamm@mellanox.com> <1525870039-11261-3-git-send-email-wisamm@mellanox.com> In-Reply-To: <1525870039-11261-3-git-send-email-wisamm@mellanox.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDJiZDM0ZWYtZTE2OC00MWNhLWFmZTUtM2M3ZTY0YjRjN2VjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoialRrenB1U2hhOTlDMmFvc0FVckdYK0tZY2hyc2Q2N1dPRlRqTkd6ZVJ2dk5EK3J1aGZEM3lSdzBYeWtRZ0xMUCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add set topology on the fly command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 May 2018 15:06:45 -0000 Hi Wisam, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wisam Jaddo > Sent: Wednesday, May 9, 2018 1:47 PM > To: Wu, Jingjing ; Lu, Wenzhuo > ; thomas@monjalon.net > Cc: rasland@mellanox.com; dev@dpdk.org; shahafs@mellanox.com; > wisamm@mellanox.com > Subject: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add set topology on the f= ly > command >=20 > Change the forward topology while testpmd is running, the valid topologie= s > are loop, paired, chained & custom. >=20 > When the forward topology is changed on the fly, all the ports will resto= re > their active status. >=20 > usage: > testpmd> set fwd-topo paired|chained|loop|custom >=20 > Signed-off-by: Wisam Jaddo > --- > app/test-pmd/cmdline.c | 42 > +++++++++++++++++++++++++++++ > app/test-pmd/config.c | 25 +++++++++++++++++ > app/test-pmd/testpmd.h | 1 + > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 ++++++ > 4 files changed, 76 insertions(+) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 9d48048..00fd4c7 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -7651,6 +7651,47 @@ cmdline_parse_inst_t cmd_set_fwd_eth_peer =3D { > NULL, > }, > }; > +/* *** SET CUSTOM TOPO FOR CERTAIN PORT *** */ struct > +cmd_set_fwd_topo_result { > + cmdline_fixed_string_t set; > + cmdline_fixed_string_t fwd_topo; > + cmdline_fixed_string_t topo; > +}; > + > +static void cmd_set_fwd_topo_parsed(void *parsed_result, > + __attribute__((unused)) struct cmdline *cl, > + __attribute__((unused)) void *data) { > + struct cmd_set_fwd_topo_result *res =3D parsed_result; > + > + if (test_done =3D=3D 0) { > + printf("Please stop forwarding first\n"); > + return; > + } > + if (!strcmp(res->fwd_topo, "fwd-topo")) { > + set_set_fwd_topo(res->topo); > + fwd_config_setup(); > + } > +} > + > +cmdline_parse_token_string_t cmd_set_fwd_topo_set =3D > + TOKEN_STRING_INITIALIZER(struct cmd_set_fwd_topo_result, set, > "set"); > +cmdline_parse_token_string_t cmd_set_fwd_topo_fwd_topo =3D > + TOKEN_STRING_INITIALIZER(struct cmd_set_fwd_topo_result, > fwd_topo, > +"fwd-topo"); cmdline_parse_token_string_t cmd_set_fwd_topo_topo =3D > + TOKEN_STRING_INITIALIZER(struct cmd_set_fwd_topo_result, topo, > NULL); > + > +cmdline_parse_inst_t cmd_set_fwd_topo =3D { > + .f =3D cmd_set_fwd_topo_parsed, > + .data =3D NULL, > + .help_str =3D "set fwd-topo loop|paired|chained|custom", > + .tokens =3D { > + (void *)&cmd_set_fwd_topo_set, > + (void *)&cmd_set_fwd_topo_fwd_topo, > + (void *)&cmd_set_fwd_topo_topo, > + NULL, > + }, > +}; >=20 > /* *** SET CUSTOM TOPO FOR CERTAIN PORT *** */ struct > cmd_custom_topo_result { @@ -16589,6 +16630,7 @@ cmdline_parse_ctx_t > main_ctx[] =3D { > (cmdline_parse_inst_t *)&cmd_mac_addr, > (cmdline_parse_inst_t *)&cmd_set_fwd_eth_peer, > (cmdline_parse_inst_t *)&cmd_set_custom_topo, > + (cmdline_parse_inst_t *)&cmd_set_fwd_topo, > (cmdline_parse_inst_t *)&cmd_set_qmap, > (cmdline_parse_inst_t *)&cmd_set_xstats_hide_zero, > (cmdline_parse_inst_t *)&cmd_operate_port, diff --git a/app/test- > pmd/config.c b/app/test-pmd/config.c index 23799ad..eaad885 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -2380,6 +2380,31 @@ set_fwd_eth_peer(portid_t port_id, char > *peer_addr) > new_peer_addr[c]; > } >=20 > +void > +set_set_fwd_topo(char *topology) > +{ > + unsigned int portlist[RTE_MAX_ETHPORTS]; > + unsigned int nb_pt =3D 0; > + unsigned int i; > + > + if (!strcmp(topology, "custom")) > + port_topology =3D PORT_TOPOLOGY_CUSTOM; > + else if (!strcmp(topology, "loop")) > + port_topology =3D PORT_TOPOLOGY_LOOP; > + else if (!strcmp(topology, "chained")) > + port_topology =3D PORT_TOPOLOGY_CHAINED; > + else if (!strcmp(topology, "paired")) > + port_topology =3D PORT_TOPOLOGY_PAIRED; > + else { > + printf("Please set valid forward topology\n"); > + printf("valid topologies are: [custom, paired, loop & > chained]\n"); > + } > + for (i =3D 0; i < RTE_MAX_ETHPORTS; i++) > + if (rte_eth_dev_is_valid_port((portid_t) i)) > + portlist[nb_pt++] =3D i; > + set_fwd_ports_list(portlist, nb_pt); > +} > + > static void > print_ports_range(void) > { > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index > 3250683..6b9db3b 100644 > --- a/app/test-pmd/testpmd.h > +++ b/app/test-pmd/testpmd.h > @@ -605,6 +605,7 @@ int init_fwd_streams(void); >=20 > void set_fwd_eth_peer(portid_t port_id, char *peer_addr); void > set_custom_topo(portid_t port_id_1, portid_t port_id_2); > +void set_set_fwd_topo(char *topology); > void port_mtu_set(portid_t port_id, uint16_t mtu); void > port_reg_bit_display(portid_t port_id, uint32_t reg_off, uint8_t bit_pos)= ; > void port_reg_bit_set(portid_t port_id, uint32_t reg_off, uint8_t bit_pos= , > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index 5edf210..584ed6b 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -1098,6 +1098,14 @@ In custom topology the active ports will be the > defiend in custum-topo only:: >=20 > testpmd> set custom-topo (port_id_1) (port_id_2) >=20 > +set fwd-topo > +~~~~~~~~~~~~ > +Set the forward topology on the fly. > +Once the forward topology is changed on the fly, all ports will restore > +it's active > +status:: > + > + testpmd> set fwd-topo loop|paired|chained|loop > + > set port-uta > ~~~~~~~~~~~~ >=20 > -- > 2.7.4 This patch does not apply to the dpdk_18_05_rc4 master branch and needs to = be rebased. It also has several checkpatch warnings which should be addressed. Regards, Bernard.