From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 41D2658FA; Thu, 17 May 2018 13:26:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 May 2018 04:26:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,410,1520924400"; d="scan'208";a="229390945" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga006.fm.intel.com with ESMTP; 17 May 2018 04:26:18 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX106.ger.corp.intel.com ([169.254.8.125]) with mapi id 14.03.0319.002; Thu, 17 May 2018 12:26:18 +0100 From: "Iremonger, Bernard" To: Adrien Mazarguil CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] maintainers: fix responsibility of flow API bits Thread-Index: AQHT7GkW6bSLl5bJnUGAOZfJNZkJB6QyE0MggABJXoCAAUu8gIAAED+AgAASC0A= Date: Thu, 17 May 2018 11:26:17 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C24E0CD93C@IRSMSX108.ger.corp.intel.com> References: <1525944544-13513-1-git-send-email-bernard.iremonger@intel.com> <20180515162211.7030-1-adrien.mazarguil@6wind.com> <8CEF83825BEC744B83065625E567D7C24E0CD20F@IRSMSX108.ger.corp.intel.com> <20180516143517.GA6497@6wind.com> <8CEF83825BEC744B83065625E567D7C24E0CD818@IRSMSX108.ger.corp.intel.com> <20180517112045.GE6497@6wind.com> In-Reply-To: <20180517112045.GE6497@6wind.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDM4ZmQ1OGYtMmNlOS00YWQ4LWI5N2QtODg1ZDFjYzA0Mzk1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS0UwYWtcL3FtOXVnU29rS2Y3ck5saGQ3MHBZaDBvVHJpOGc4VElIVmJpT3RjazUxMExzWmh4M3VTVEUrS285VlcifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] maintainers: fix responsibility of flow API bits X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 11:26:21 -0000 Hi Adrien, > > > > > Subject: [PATCH] maintainers: fix responsibility of flow API > > > > > bits > > > > > > > > > > The following commits lack MAINTAINERS entries for this mess. > > > > > > > > > > Fixes: 4d73b6fb9907 ("doc: add generic flow API guide") > > > > > Fixes: 19c90af6285c ("app/testpmd: add flow command") > > > > > Cc: stable@dpdk.org > > > > > > > > > > Signed-off-by: Adrien Mazarguil > > > > > Cc: Bernard Iremonger > > > > > --- > > > > > MAINTAINERS | 2 ++ > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS index > > > > > bd08d4292..187817fff > > > > > 100644 > > > > > --- a/MAINTAINERS > > > > > +++ b/MAINTAINERS > > > > > @@ -303,6 +303,8 @@ F: devtools/test-null.sh Flow API > > > > > M: Adrien Mazarguil > > > > > T: git://dpdk.org/next/dpdk-next-net > > > > > +F: app/test-pmd/cmdline_flow.c > > > > > +F: doc/guides/prog_guide/rte_flow.rst > > > > > > > > doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > > Should be added to the list of flow related files. > > > > > > I did not add it because there is no way to split responsibility on > > > a documentation section basis AFAIK, and only a fraction of this > > > file contains information about rte_flow-related stuff. > > > > > > -- > > > Adrien Mazarguil > > > 6WIND > > > > There are already several maintainers for testpmd, adding another maint= ainer > for the flow parts of this file should be ok (I think). >=20 > True, however providing an exact file name instead of a directory or wild= card > makes me the main maintainer/contact for that specific file (e.g. "app/te= st- > pmd/cmdline_flow.c" vs. "app/test-pmd"), basically I do not want to be > responsible for the entirety of testpmd's documentation. >=20 > How about the following instead: another patch that extracts the flow > command documentation in its own file (testpmd_flow.rst?) using the inclu= de > directive (somewhat like cmdline_flow.c). This patch will update MAINTAIN= ERS > accordingly. >=20 > -- > Adrien Mazarguil > 6WIND Sounds good to me. Regards, Bernard.