Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

["Iremonger, Bernard" <bernard.iremonger@intel.com>]

Hi Ferruh, Zhiyong,

<snip> 

> > Subject: [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs
> >
> > For vdev, just calling rte_eth_dev_close() isn't enough to free all
> > the resources allocated during device probe, e.g. for virtio-user,
> > virtio_user_pmd_remove(), i.e. the remove() method of a vdev driver,
> > needs to be called to unlink the socket file created during device
> > probe. So this patch calls the rte_eth_dev_detach() for vdev when
> > quitting testpmd.
> >
> > Cc: maxime.coquelin@redhat.com
> > Cc: ferruh.yigit@intel.com
> > Cc: tiwei.bie@intel.com
> > Cc: lei.a.yao@intel.com
> > Cc: bernard.iremonger@intel.com
> > Cc: stable@dpdk.org
> >
> > Fixes: af75078fece3 ("first public release")
> > Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
> >
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> Tested-by: Lei Yao<lei.a.yao@intel.com>
> This patch pass the test for virtio-user server mode. The socket file can be
> deleted after quit testpmd.

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

Hi Ferruh,

Check-git-log is showing some errors:

./devtools/check-git-log.sh -1
Wrong headline format:
        app/testpmd: fix pmd_test_exit function for vdevs
Wrong tag:
        Tested-by: Lei Yao<lei.a.yao@intel.com>

Can you fix these while merging or is a v3 needed?

Regards,

Bernard.