From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id EE4B2AAD4; Fri, 18 May 2018 12:18:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 May 2018 03:18:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,414,1520924400"; d="scan'208";a="225304009" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga005.jf.intel.com with ESMTP; 18 May 2018 03:18:49 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX102.ger.corp.intel.com ([169.254.2.83]) with mapi id 14.03.0319.002; Fri, 18 May 2018 11:18:48 +0100 From: "Iremonger, Bernard" To: "Yao, Lei A" , "Yang, Zhiyong" , "dev@dpdk.org" CC: "maxime.coquelin@redhat.com" , "Yigit, Ferruh" , "Bie, Tiwei" , "stable@dpdk.org" Thread-Topic: [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs Thread-Index: AQHT7k9T9PwTG/8zdUm6UHcjOtfpQKQ02o+AgABpBUA= Date: Fri, 18 May 2018 10:18:47 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C24E0CDF86@IRSMSX108.ger.corp.intel.com> References: <20180518095937.28710-1-zhiyong.yang@intel.com> <2DBBFF226F7CF64BAFCA79B681719D953A44B1E4@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A44B1E4@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmZhOWE2OGMtYmVjMS00MzA5LTkyYTctYzYzNzg5Mjc5MDM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieFBoOEpIUE1PeEwyV3JaYVJjUWRkNE5pNndMZ2NxYVRMV1RDYTJ0V0N4dm5NZFpyOWN3bEg1b0l3XC9LdGlScysifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2018 10:18:52 -0000 Hi Ferruh, Zhiyong, =20 > > Subject: [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs > > > > For vdev, just calling rte_eth_dev_close() isn't enough to free all > > the resources allocated during device probe, e.g. for virtio-user, > > virtio_user_pmd_remove(), i.e. the remove() method of a vdev driver, > > needs to be called to unlink the socket file created during device > > probe. So this patch calls the rte_eth_dev_detach() for vdev when > > quitting testpmd. > > > > Cc: maxime.coquelin@redhat.com > > Cc: ferruh.yigit@intel.com > > Cc: tiwei.bie@intel.com > > Cc: lei.a.yao@intel.com > > Cc: bernard.iremonger@intel.com > > Cc: stable@dpdk.org > > > > Fixes: af75078fece3 ("first public release") > > Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") > > > > Signed-off-by: Zhiyong Yang > Tested-by: Lei Yao > This patch pass the test for virtio-user server mode. The socket file can= be > deleted after quit testpmd. Acked-by: Bernard Iremonger Hi Ferruh, Check-git-log is showing some errors: ./devtools/check-git-log.sh -1 Wrong headline format: app/testpmd: fix pmd_test_exit function for vdevs Wrong tag: Tested-by: Lei Yao Can you fix these while merging or is a v3 needed? Regards, Bernard.