* [dpdk-dev] [PATCH] app/testpmd: fix descriptor number for Rx queue setup
@ 2018-05-22 16:37 Ferruh Yigit
2018-05-22 17:20 ` Iremonger, Bernard
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-05-22 16:37 UTC (permalink / raw)
To: Wenzhuo Lu, Jingjing Wu; +Cc: dev, Ferruh Yigit, Qi Zhang, Bernard Iremonger
Wrong index used to select descriptor number, causing setting up queue
with wrong number of descriptors.
Fixes: d44f8a485f5d ("app/testpmd: enable per queue configure")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Qi Zhang <qi.z.zhang@intel.com>
Cc: Bernard Iremonger <bernard.iremonger@intel.com>
---
app/test-pmd/testpmd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index cfa6da60c..5f8f88449 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1689,7 +1689,7 @@ start_port(portid_t pid)
}
diag = rte_eth_rx_queue_setup(pi, qi,
- port->nb_rx_desc[pi],
+ port->nb_rx_desc[qi],
rxring_numa[pi],
&(port->rx_conf[qi]),
mp);
@@ -1704,7 +1704,7 @@ start_port(portid_t pid)
return -1;
}
diag = rte_eth_rx_queue_setup(pi, qi,
- port->nb_rx_desc[pi],
+ port->nb_rx_desc[qi],
port->socket_id,
&(port->rx_conf[qi]),
mp);
--
2.14.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix descriptor number for Rx queue setup
2018-05-22 16:37 [dpdk-dev] [PATCH] app/testpmd: fix descriptor number for Rx queue setup Ferruh Yigit
@ 2018-05-22 17:20 ` Iremonger, Bernard
2018-05-22 18:53 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Iremonger, Bernard @ 2018-05-22 17:20 UTC (permalink / raw)
To: Yigit, Ferruh, Lu, Wenzhuo, Wu, Jingjing; +Cc: dev, Zhang, Qi Z
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, May 22, 2018 5:37 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Subject: [PATCH] app/testpmd: fix descriptor number for Rx queue setup
>
> Wrong index used to select descriptor number, causing setting up queue
> with wrong number of descriptors.
>
> Fixes: d44f8a485f5d ("app/testpmd: enable per queue configure")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix descriptor number for Rx queue setup
2018-05-22 17:20 ` Iremonger, Bernard
@ 2018-05-22 18:53 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-05-22 18:53 UTC (permalink / raw)
To: Iremonger, Bernard, Lu, Wenzhuo, Wu, Jingjing; +Cc: dev, Zhang, Qi Z
On 5/22/2018 6:20 PM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Tuesday, May 22, 2018 5:37 PM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>; Iremonger, Bernard
>> <bernard.iremonger@intel.com>
>> Subject: [PATCH] app/testpmd: fix descriptor number for Rx queue setup
>>
>> Wrong index used to select descriptor number, causing setting up queue
>> with wrong number of descriptors.
>>
>> Fixes: d44f8a485f5d ("app/testpmd: enable per queue configure")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-22 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-22 16:37 [dpdk-dev] [PATCH] app/testpmd: fix descriptor number for Rx queue setup Ferruh Yigit
2018-05-22 17:20 ` Iremonger, Bernard
2018-05-22 18:53 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).