From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 97CC41200A for ; Thu, 7 Jun 2018 14:53:02 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jun 2018 05:53:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,486,1520924400"; d="scan'208";a="230686717" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga005.jf.intel.com with ESMTP; 07 Jun 2018 05:53:00 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by irsmsx105.ger.corp.intel.com ([169.254.7.126]) with mapi id 14.03.0319.002; Thu, 7 Jun 2018 13:52:59 +0100 From: "Iremonger, Bernard" To: Stephen Hemminger , "dev@dpdk.org" CC: "Iremonger, Bernard" Thread-Topic: [dpdk-dev] [RFC] testpmd: use RFC2544 reserved IP addresses Thread-Index: AQHTwMcLj1qxkGM+EEem0R5xeUjJLKRVN5xg Date: Thu, 7 Jun 2018 12:52:59 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260CAF443@IRSMSX108.ger.corp.intel.com> References: <20180321034436.4089-1-stephen@networkplumber.org> In-Reply-To: <20180321034436.4089-1-stephen@networkplumber.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTcxNzZkOTItZmFmNy00ZjMxLTk2MGMtYTY3MTFkYmNiZTY4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiajVYekU3OEJ5bDlcLzk5VlFWbFRSblgybFFTWGgwdGdzRmNia1BPelgyWGtaNlRrVDNob2tlSktMdXRHV3pRbk0ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC] testpmd: use RFC2544 reserved IP addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2018 12:53:03 -0000 Hi Stephen, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Wednesday, March 21, 2018 3:45 AM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [RFC] testpmd: use RFC2544 reserved IP addresses >=20 > Change the transmit only side of testpmd to use the IP addresses that are > marked as reserved for benchmarking by RFC2544 192.18.0.0/27; rather than RFC2544 seems to use 198.18.0.0 and 198.19.0.0 ? > the commonly used subnet 192.168.0.0/24 which is likely to used for > administrative interface. Typo in the commit message "to used" should be "to be used" >=20 > Signed-off-by: Stephen Hemminger > --- > app/test-pmd/txonly.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index > 1f08b6ed37a2..22785bdcbe44 100644 > --- a/app/test-pmd/txonly.c > +++ b/app/test-pmd/txonly.c > @@ -43,8 +43,9 @@ > #define UDP_SRC_PORT 1024 > #define UDP_DST_PORT 1024 >=20 > -#define IP_SRC_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 1) -#define > IP_DST_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 2) > +/* RFC 2544 reserved IP addresses for benchmarking */ #define > +IP_SRC_ADDR ((192U << 24) | (18 << 16) | (0 << 8) | 1) #define > +IP_DST_ADDR ((192U << 24) | (18 << 16) | (0 << 8) | 2) >=20 > #define IP_DEFTTL 64 /* from RFC 1340. */ > #define IP_VERSION 0x40 > -- > 2.16.2 >>From RFC 2544: "The single filter case should permit traffic from IP address 198.18.1.2 t= o IP address 198.19.65.2 and deny all other traffic." Should the macros be as follows? #define IP_SRC_ADDR ((198U << 24) | (18 << 16) | (0 << 8) | 1) #define IP_DST_ADDR ((198U << 24) | (19 << 16) | (0 << 8) | 2) Regards, Bernard