From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B546F5B2C for ; Tue, 26 Jun 2018 10:55:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2018 01:55:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,274,1526367600"; d="scan'208";a="52305796" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga008.jf.intel.com with ESMTP; 26 Jun 2018 01:55:05 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by irsmsx105.ger.corp.intel.com (163.33.3.28) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 26 Jun 2018 09:55:05 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.139]) by IRSMSX156.ger.corp.intel.com ([169.254.3.252]) with mapi id 14.03.0319.002; Tue, 26 Jun 2018 09:55:05 +0100 From: "Iremonger, Bernard" To: "Singh, Jasvinder" , "dev@dpdk.org" CC: "Dumitrescu, Cristian" , "Pattan, Reshma" Thread-Topic: [dpdk-dev] [PATCH v2 22/22] app/testpmd: rework softnic forward mode Thread-Index: AQHUBMnxem1e1GcuEUGpMD28e6xor6RySzfA Date: Tue, 26 Jun 2018 08:55:04 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260CB8923@IRSMSX108.ger.corp.intel.com> References: <20180608124155.140663-2-jasvinder.singh@intel.com> <20180615165224.25004-1-jasvinder.singh@intel.com> <20180615165224.25004-23-jasvinder.singh@intel.com> In-Reply-To: <20180615165224.25004-23-jasvinder.singh@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWVmMDE2OTUtMTNmNC00ZDUyLWI0MmQtNDQxYWY0YmIxMzE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM3lqUVlWTnNIXC9DaXlhWkd5aCtEYlhyTDJZMjJDQ0tcL0F4OFR1dkVYbXlQSUpLYmZMYWF2WlNPOGZXMjhnbHd0In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 22/22] app/testpmd: rework softnic forward mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2018 08:55:08 -0000 Hi Jasvinder > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Friday, June 15, 2018 5:52 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Pattan, Reshma > > Subject: [dpdk-dev] [PATCH v2 22/22] app/testpmd: rework softnic forward > mode >=20 > Modied the testpmd softnic forwarding mode as per the changes in softnic = PMD. >=20 > To run testpmd application with softnic fwd mode, following command is us= ed; >=20 > $ ./testpmd -c 0xc -n 4 --vdev 'net_softnic0,firware=3Dscript.cli' > -- -i --forward-mode=3Dsoftnic >=20 > Signed-off-by: Jasvinder Singh > Signed-off-by: Reshma Pattan > --- > app/test-pmd/Makefile | 4 +- > app/test-pmd/cmdline.c | 53 ++++- > app/test-pmd/config.c | 55 +++++ > app/test-pmd/{tm.c =3D> softnicfwd.c} | 418 ++++++++++++----------------= -------- > app/test-pmd/testpmd.c | 27 ++- > app/test-pmd/testpmd.h | 44 +--- > 6 files changed, 256 insertions(+), 345 deletions(-) rename app/test-pm= d/{tm.c > =3D> softnicfwd.c} (61%) >=20 This patch fails to compile when applied the current dpdk 18_08 master. /root/dpdk_sforge_2/app/test-pmd/cmdline.c: In function 'prompt': /root/dpdk_sforge_2/app/test-pmd/cmdline.c:17583:3: error: implicit declara= tion of function 'rte_pmd_softnic_manage' [-Werror=3Dimplicit-function-decl= aration] rte_pmd_softnic_manage(softnic_portid); ^ /root/dpdk_sforge_2/app/test-pmd/cmdline.c:17583:3: error: nested extern de= claration of 'rte_pmd_softnic_manage' [-Werror=3Dnested-externs] It is also giving the following checkpatch errors and warnings: WARNING: 'firware' may be misspelled - perhaps 'firmware'? #24:=20 $ ./testpmd -c 0xc -n 4 --vdev 'net_softnic0,firware=3Dscript.cli' WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #33:=20 app/test-pmd/{tm.c =3D> softnicfwd.c} | 418 ++++++++++++------------------= ------ WARNING: Missing a blank line after declarations #107: FILE: app/test-pmd/cmdline.c:17554: + uint8_t softnic_enable =3D 0; + if (strcmp(cur_fwd_eng->fwd_mode_name, "softnic") =3D=3D 0) { WARNING: line over 80 characters #110: FILE: app/test-pmd/cmdline.c:17557: + if (strcmp(port->dev_info.driver_name, "net_softnic= ") =3D=3D 0) { WARNING: line over 80 characters #163: FILE: app/test-pmd/config.c:2346: + if (strcmp(port->dev_info.driver_name, "net_softnic= ") =3D=3D 0) { ERROR: spaces required around that '=3D' (ctx:WxV) #165: FILE: app/test-pmd/config.c:2348: + softnic_enable =3D1; ^ WARNING: line over 80 characters #171: FILE: app/test-pmd/config.c:2354: + printf("Softnicfwd mode configuration not complete(%s)!\n",= __func__); ERROR: space required before the open parenthesis '(' #208: FILE: app/test-pmd/config.c:2392: + if(strcmp(cur_fwd_eng->fwd_mode_name, "softnic") =3D=3D 0) { ERROR: space required before the open parenthesis '(' #437: FILE: app/test-pmd/softnicfwd.c:150: + for(;;) { WARNING: void function return statements are not generally useful #445: FILE: app/test-pmd/softnicfwd.c:158: + return; +} ERROR: open brace '{' following function definitions go on the next line #449: FILE: app/test-pmd/softnicfwd.c:162: +static int +softnic_begin(void *arg __rte_unused) { ERROR: space required before the open parenthesis '(' #456: FILE: app/test-pmd/softnicfwd.c:169: + } while(!softnic_fwd_lcore->stopped); WARNING: void function return statements are not generally useful #713: FILE: app/test-pmd/softnicfwd.c:683: + return; +} WARNING: adding a line without newline at end of file #722: FILE: app/test-pmd/softnicfwd.c:690: +}; WARNING: line over 80 characters #749: FILE: app/test-pmd/testpmd.c:823: + if (strcmp(port->dev_info.driver_name, "net_softnic= ") =3D=3D 0) total: 5 errors, 10 warnings, 768 lines checked Regards, Bernard