From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 6D6E798 for ; Tue, 24 Jul 2018 11:09:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2018 02:09:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,397,1526367600"; d="scan'208";a="218594597" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga004.jf.intel.com with ESMTP; 24 Jul 2018 02:08:59 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by irsmsx105.ger.corp.intel.com ([169.254.7.195]) with mapi id 14.03.0319.002; Tue, 24 Jul 2018 10:08:58 +0100 From: "Iremonger, Bernard" To: Krzysztof Kanas , "dev@dpdk.org" , "Lu, Wenzhuo" , "Wu, Jingjing" CC: Nithin Dabilpuram , "Singh, Jasvinder" Thread-Topic: [PATCH v2 2/2] app/testpmd: fix help string for tm commit cmd Thread-Index: AQHUHn3E2/0nugeDREiMxDbPJR5q76SeHdbg Date: Tue, 24 Jul 2018 09:08:57 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260CCEC76@IRSMSX107.ger.corp.intel.com> References: <8CEF83825BEC744B83065625E567D7C260CCCFA0@IRSMSX107.ger.corp.intel.com> <20180718095443.31429-1-krzysztof.kanas@caviumnetworks.com> In-Reply-To: <20180718095443.31429-1-krzysztof.kanas@caviumnetworks.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmY4MjJkZGUtMTJmMS00MjkxLWExYzMtZjlmNjllY2E4NTg1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidktydnZHTXlqRkVCUGxmM2RmM3ZJTG9oTkl0VDRYcW1YcDdFM1wvVTBYYlwvNVdKK0FTeG1HZjFWaFNDS1VTN1FRIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: fix help string for tm commit cmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 09:09:03 -0000 Hi Krzysztof > -----Original Message----- > From: Krzysztof Kanas [mailto:krzysztof.kanas@caviumnetworks.com] > Sent: Wednesday, July 18, 2018 10:55 AM > To: Iremonger, Bernard ; > krzysztof.kanas@caviumnetworks.com; dev@dpdk.org; Lu, Wenzhuo > ; Wu, Jingjing > Cc: Nithin Dabilpuram ; Singh, Jasvinder > > Subject: [PATCH v2 2/2] app/testpmd: fix help string for tm commit cmd >=20 > Fixes: bd475cefc7cb ("app/testpmd: fix use of uninitialized field") > Cc: krzysztof.kanas@caviumnetworks.com >=20 > Signed-off-by: Krzysztof Kanas > --- > v2: > * Fix the Fixes commit message line > --- > app/test-pmd/cmdline_tm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c index > 4f515241703a..09acc1b87293 100644 > --- a/app/test-pmd/cmdline_tm.c > +++ b/app/test-pmd/cmdline_tm.c > @@ -2172,7 +2172,7 @@ static void > cmd_port_tm_hierarchy_commit_parsed(void *parsed_result, > cmdline_parse_inst_t cmd_port_tm_hierarchy_commit =3D { > .f =3D cmd_port_tm_hierarchy_commit_parsed, > .data =3D NULL, > - .help_str =3D "Set port tm node shaper profile", > + .help_str =3D "Commit port tm hierarchy", > .tokens =3D { > (void *)&cmd_port_tm_hierarchy_commit_port, > (void *)&cmd_port_tm_hierarchy_commit_tm, > -- > 2.18.0 The check-git-log script is still showing an error: ./devtools/check-git-log.sh -1 Wrong 'Fixes' reference: Fixes: bd475cefc7cb ("app/testpmd: fix use of uninitialized field") It is better to send the complete patch set (2 patches) with each revision. My ack can be carried forward on the first patch. Regards, Bernard.