From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 3464B2B92 for ; Thu, 30 Aug 2018 11:26:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Aug 2018 02:26:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,306,1531810800"; d="scan'208";a="67107879" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga008.fm.intel.com with ESMTP; 30 Aug 2018 02:26:30 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.116]) by irsmsx110.ger.corp.intel.com ([169.254.15.28]) with mapi id 14.03.0319.002; Thu, 30 Aug 2018 10:26:29 +0100 From: "Iremonger, Bernard" To: "Finn, Emma" , "dev@dpdk.org" CC: "Mcnamara, John" , "Yigit, Ferruh" , "stephen@networkplumber.org" Thread-Topic: [PATCH v3] app/testpmd: add new command for show port info Thread-Index: AQHUP4W2Yom4MrKdjUuHt71wiwSztKTYBxAA Date: Thu, 30 Aug 2018 09:26:28 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260CEA2FD@IRSMSX107.ger.corp.intel.com> References: <1535536120-6934-1-git-send-email-emma.finn@intel.com> <1535539649-7385-1-git-send-email-emma.finn@intel.com> In-Reply-To: <1535539649-7385-1-git-send-email-emma.finn@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWViMDljZWQtNzMzMC00ZDNhLTg3ZTQtOTk1OTcxMGI0YTBlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiR0E0d1NQd2h1bjg5MVR1aCtZcEh5OTFHWHNlaTFFbkw5UFRMZGNYYytnRnFvQTMzOFlQZ1hVT05VQ2thaVNibyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: add new command for show port info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2018 09:26:32 -0000 Hi Emma, > -----Original Message----- > From: Finn, Emma > Sent: Wednesday, August 29, 2018 11:47 AM > To: dev@dpdk.org > Cc: Mcnamara, John ; Yigit, Ferruh > ; Iremonger, Bernard ; > stephen@networkplumber.org; Finn, Emma > Subject: [PATCH v3] app/testpmd: add new command for show port info >=20 > existing testpmd command "show port info" is too verbose. > Added a new summary command to print brief information on ports. >=20 > console output: > testpmd> show port summary all > Number of available ports: 2 > Port MAC Address Name Driver Status Link > 0 11:22:33:44:55:66 0000:07:00.0, net_i40e, up, 40000 Mbps > 1 66:55:44:33:22:11 0000:07:00.1, net_i40e, up, 40000 Mbps >=20 > Signed-off-by: Emma Finn >=20 > --- >=20 > v2: droped off redundant information added > a single header line. (Stephen Hemminger) >=20 > v3: removed deprecated function and refactored code. > --- > app/test-pmd/cmdline.c | 19 +++++++++++---- > app/test-pmd/config.c | 37 +++++++++++++++++++++++= ++++++ > app/test-pmd/testpmd.h | 2 ++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 +++- > 4 files changed, 56 insertions(+), 6 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 589121d..e54e2e5 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -167,7 +167,7 @@ static void cmd_help_long_parsed(void *parsed_result, > "Display:\n" > "--------\n\n" >=20 > - "show port > (info|stats|xstats|fdir|stat_qmap|dcb_tc|cap) (port_id|all)\n" > + "show port > (info|stats|summary|xstats|fdir|stat_qmap|dcb_tc|cap) (port_id|all)\n" > " Display information for port_id, or all.\n\n" >=20 > "show port X rss reta (size) (mask0,mask1,...)\n" > @@ -7073,6 +7073,11 @@ static void cmd_showportall_parsed(void > *parsed_result, > } else if (!strcmp(res->what, "info")) > RTE_ETH_FOREACH_DEV(i) > port_infos_display(i); > + else if (!strcmp(res->what, "summary")) { > + port_summary_header_display(); > + RTE_ETH_FOREACH_DEV(i) > + port_summary_display(i); > + } > else if (!strcmp(res->what, "stats")) > RTE_ETH_FOREACH_DEV(i) > nic_stats_display(i); > @@ -7100,14 +7105,14 @@ cmdline_parse_token_string_t > cmd_showportall_port =3D > TOKEN_STRING_INITIALIZER(struct cmd_showportall_result, port, > "port"); cmdline_parse_token_string_t cmd_showportall_what =3D > TOKEN_STRING_INITIALIZER(struct cmd_showportall_result, what, > - > "info#stats#xstats#fdir#stat_qmap#dcb_tc#cap"); > + > "info#summary#stats#xstats#fdir#stat_qmap#dcb_tc#cap"); > cmdline_parse_token_string_t cmd_showportall_all =3D > TOKEN_STRING_INITIALIZER(struct cmd_showportall_result, all, "all"); > cmdline_parse_inst_t cmd_showportall =3D { > .f =3D cmd_showportall_parsed, > .data =3D NULL, > .help_str =3D "show|clear port " > - "info|stats|xstats|fdir|stat_qmap|dcb_tc|cap all", > + "info|summary|stats|xstats|fdir|stat_qmap|dcb_tc|cap all", > .tokens =3D { > (void *)&cmd_showportall_show, > (void *)&cmd_showportall_port, > @@ -7137,6 +7142,10 @@ static void cmd_showport_parsed(void > *parsed_result, > nic_xstats_clear(res->portnum); > } else if (!strcmp(res->what, "info")) > port_infos_display(res->portnum); > + else if (!strcmp(res->what, "summary")) { > + port_summary_header_display(); > + port_summary_display(res->portnum); > + } > else if (!strcmp(res->what, "stats")) > nic_stats_display(res->portnum); > else if (!strcmp(res->what, "xstats")) @@ -7158,7 +7167,7 @@ > cmdline_parse_token_string_t cmd_showport_port =3D > TOKEN_STRING_INITIALIZER(struct cmd_showport_result, port, "port"); > cmdline_parse_token_string_t cmd_showport_what =3D > TOKEN_STRING_INITIALIZER(struct cmd_showport_result, what, > - > "info#stats#xstats#fdir#stat_qmap#dcb_tc#cap"); > + > "info#summary#stats#xstats#fdir#stat_qmap#dcb_tc#cap"); > cmdline_parse_token_num_t cmd_showport_portnum =3D > TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, > UINT16); >=20 > @@ -7166,7 +7175,7 @@ cmdline_parse_inst_t cmd_showport =3D { > .f =3D cmd_showport_parsed, > .data =3D NULL, > .help_str =3D "show|clear port " > - "info|stats|xstats|fdir|stat_qmap|dcb_tc|cap " > + "info|summary|stats|xstats|fdir|stat_qmap|dcb_tc|cap " > "", > .tokens =3D { > (void *)&cmd_showport_show, > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > 14ccd68..237efc3 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -518,6 +518,43 @@ port_infos_display(portid_t port_id) } >=20 > void > +port_summary_header_display(void) > +{ > + uint16_t port_number; > + > + port_number =3D rte_eth_dev_count_avail(); > + printf("Number of available ports: %i\n", port_number); > + printf("%s %s %10s %15s %8s %s\n", "Port", "MAC Address", "Name", > + "Driver", "Status", "Link"); > +} > + > +void > +port_summary_display(portid_t port_id) > +{ > + struct ether_addr mac_addr; > + struct rte_eth_link link; > + struct rte_eth_dev_info dev_info; > + char name[RTE_ETH_NAME_MAX_LEN]; > + > + if (port_id_is_invalid(port_id, ENABLED_WARN)) { > + print_valid_ports(); > + return; > + } > + > + rte_eth_link_get_nowait(port_id, &link); > + rte_eth_dev_info_get(port_id, &dev_info); > + rte_eth_dev_get_name_by_port(port_id, name); > + rte_eth_macaddr_get(port_id, &mac_addr); > + > + printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %s, %s, %s, %u > Mbps\n", > + port_id, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1], > + mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], > + mac_addr.addr_bytes[4], mac_addr.addr_bytes[5], name, > + dev_info.driver_name, (link.link_status) ? ("up") : ("down"), > + (unsigned) link.link_speed); > +} The checkpatch warning in the line above should probably be fixed. WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #157: FILE: app/test-pmd/config.c:554: + (unsigned) link.link_speed); > + > +void > port_offload_cap_display(portid_t port_id) { > struct rte_eth_dev_info dev_info; > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index > a1f6614..f0bc716 100644 > --- a/app/test-pmd/testpmd.h > +++ b/app/test-pmd/testpmd.h > @@ -594,6 +594,8 @@ void nic_xstats_display(portid_t port_id); void > nic_xstats_clear(portid_t port_id); void nic_stats_mapping_display(porti= d_t > port_id); void port_infos_display(portid_t port_id); > +void port_summary_display(portid_t port_id); void > +port_summary_header_display(void); > void port_offload_cap_display(portid_t port_id); void > rx_queue_infos_display(portid_t port_idi, uint16_t queue_id); void > tx_queue_infos_display(portid_t port_idi, uint16_t queue_id); diff --git > a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index dde205a..23c4feb 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -159,12 +159,14 @@ show port >=20 > Display information for a given port or all ports:: >=20 > - testpmd> show port (info|stats|xstats|fdir|stat_qmap|dcb_tc|cap) > (port_id|all) > + testpmd> show port > + (info|summary|stats|xstats|fdir|stat_qmap|dcb_tc|cap) (port_id|all) >=20 > The available information categories are: >=20 > * ``info``: General port information such as MAC address. >=20 > +* ``summary``: Brief port summary such as Device Name, Driver Name etc. > + > * ``stats``: RX/TX statistics. >=20 > * ``xstats``: RX/TX extended NIC statistics. > -- > 2.7.4 Regards, Bernard.