From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 360935F19 for ; Tue, 2 Oct 2018 17:35:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2018 08:35:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,332,1534834800"; d="scan'208";a="74812716" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga007.fm.intel.com with ESMTP; 02 Oct 2018 08:34:24 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by IRSMSX101.ger.corp.intel.com ([169.254.1.4]) with mapi id 14.03.0319.002; Tue, 2 Oct 2018 16:34:23 +0100 From: "Iremonger, Bernard" To: Jerin Jacob , Krzysztof Kanas CC: "dev@dpdk.org" , "Jerin.JacobKollanukkaran@cavium.com" , "Nithin.Dabilpuram@cavium.com" , "Lu, Wenzhuo" , "Wu, Jingjing" , "Dumitrescu, Cristian" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: add commands for TM to mark pkts Thread-Index: AQHUSRyM2UwWNuPQ2USmqTKlPVbc6aUMN9Rw Date: Tue, 2 Oct 2018 15:34:22 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D0BBCC@IRSMSX107.ger.corp.intel.com> References: <20180817113919.32095-1-krzysztof.kanas@caviumnetworks.com> <20180910153938.GA20620@jerin> In-Reply-To: <20180910153938.GA20620@jerin> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTMxN2JmMWUtOTViOS00NWMyLWExMzktMDEyN2YwMmE3NDJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWnUrWXFidFRVXC9vSVZKY0RhaFRQY09YWVpZTU13aGFjUlZ5YnpsRms4TnQzUWFsS2pqbmFlS2MyZkFtUEZiOWgifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add commands for TM to mark pkts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 15:35:14 -0000 Hi Jerin > > Subject: [dpdk-dev] [PATCH] app/testpmd: add commands for TM to mark > > pkts > > X-Mailer: git-send-email 2.18.0 > > > > Add following testpmd run-time commands to support test of TM packet > > marking: > > > > set port tm mark ip_ecn > > set port tm mark ip_dscp set port tm > > mark vlan_dei > > > > Signed-off-by: Krzysztof Kanas > > --- > > app/test-pmd/cmdline.c | 3 + > > app/test-pmd/cmdline_tm.c | 260 ++++++++++++++++++++ > > app/test-pmd/cmdline_tm.h | 3 + >=20 > + Cristian, Wenzhuo, Jingjing, Bernard >=20 > In addition to this slow path change, IMO, we need test engine similar to > checksum(app/test-pmd/csumonly.c) to generate traffic(app/test- > pmd/markonly.c) with struct rte_mbuf::tx_offload populated so that we can= test > the packet marking. >=20 > Cristian, >=20 > Any thoughts as a rte_tm maintainer? I would suggest someone familiar with the Traffic Management code as a main= tainer for the TM code in testpmd.=20 Regards, Bernard.