From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0AAA5D0B2 for ; Wed, 3 Oct 2018 12:52:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2018 03:52:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,335,1534834800"; d="scan'208";a="95670026" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga001.fm.intel.com with ESMTP; 03 Oct 2018 03:52:57 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by IRSMSX101.ger.corp.intel.com ([169.254.1.4]) with mapi id 14.03.0319.002; Wed, 3 Oct 2018 11:52:56 +0100 From: "Iremonger, Bernard" To: Jerin Jacob , "Lu, Wenzhuo" , "Wu, Jingjing" , "Mcnamara, John" , "Kovacevic, Marko" , Thomas Monjalon , "Yigit, Ferruh" , Andrew Rybchenko , Olivier Matz CC: "dev@dpdk.org" , "shahafs@mellanox.com" Thread-Topic: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP checksum definition Thread-Index: AQHUWoW4X0B7t7XA7Ui/32uUcZ0v6qUNWRyA Date: Wed, 3 Oct 2018 10:52:56 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D0C0E0@IRSMSX107.ger.corp.intel.com> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181002192451.19119-1-jerin.jacob@caviumnetworks.com> <20181002192451.19119-2-jerin.jacob@caviumnetworks.com> In-Reply-To: <20181002192451.19119-2-jerin.jacob@caviumnetworks.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjc5NGQ5NzEtMjBiMC00NTcyLTllYTgtMzZhZDRiZWQ0NWY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiajZYMkRmcEFWUWg5cTcreW5nQkdLcE5vT21IMnRMc3lidFB1OXpoTU5Ib1dSUXQxVnhEVk1oMUZyZnFHMVMyViJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP checksum definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 10:53:00 -0000 Hi Jerin, > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Tuesday, October 2, 2018 8:25 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard = ; > Mcnamara, John ; Kovacevic, Marko > ; Thomas Monjalon ; > Yigit, Ferruh ; Andrew Rybchenko > ; Olivier Matz > Cc: dev@dpdk.org; shahafs@mellanox.com; Jerin Jacob > > Subject: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP check= sum > definition >=20 > Introduced DEV_TX_OFFLOAD_OUTER_UDP_CKSUM offload flags and > PKT_TX_OUTER_TCP_CKSUM mbuf ol_flags to enable Tx outer UDP checksum > offload. >=20 > To use hardware Tx outer UDP checksum offload, the user needs to, >=20 > - enable following in mbuff: > a) fill outer_l2_len and outer_l3_len in mbuf > b) set the PKT_TX_OUTER_UDP_CKSUM flag > c) set the flag PKT_TX_OUTER_IPV4 or PKT_TX_OUTER_IPV6 >=20 > - configure DEV_TX_OFFLOAD_OUTER_UDP_CKSUM offload flags in slow path >=20 > Signed-off-by: Jerin Jacob > --- >=20 > v2: > - Removed DEV_TX_OFFLOAD_OUTER_TCP_CKSUM and > DEV_TX_OFFLOAD_OUTER_SCTP_CKSUM as there is no realworld use case for > it. > See: http://patches.dpdk.org/patch/44692/ >=20 > This patch series is depended on http://patches.dpdk.org/patch/45840/ >=20 > --- > app/test-pmd/config.c | 10 ++++++++++ > doc/guides/nics/features.rst | 6 ++++++ > lib/librte_ethdev/rte_ethdev.c | 1 + > lib/librte_ethdev/rte_ethdev.h | 2 ++ > lib/librte_mbuf/rte_mbuf.c | 1 + > lib/librte_mbuf/rte_mbuf.h | 6 +++++- > 6 files changed, 25 insertions(+), 1 deletion(-) >=20 This patch fails to apply to the latest master branch, a rebase may be need= ed. Regards, Bernard.