DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Gaetan Rivet <gaetan.rivet@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] testpmd: sfp eeprom display
Date: Mon, 8 Oct 2018 10:36:08 +0000	[thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260D0DC07@IRSMSX107.ger.corp.intel.com> (raw)
In-Reply-To: <8fccc9432769b39d66e909945501ee4a0027f538.1538776598.git.gaetan.rivet@6wind.com>

Hi Gaetan

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gaetan Rivet
> Sent: Friday, October 5, 2018 10:59 PM
> To: dev@dpdk.org
> Cc: Gaetan Rivet <gaetan.rivet@6wind.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>
> Subject: [dpdk-dev] [PATCH v2] testpmd: sfp eeprom display

./devtools/check-git-log.sh 
Wrong headline format:
        myscripts: add setup_dpdk.sh
Wrong headline label:
        testpmd: sfp eeprom display
Wrong headline lowercase:
        testpmd: sfp eeprom display

> 
> The interactive command
> 
>   show port sfp_eeprom <id>
> 
> will dump the content of the SFP EEPROM for the selected port.
> Dumping SFP eeprom of all ports at once is not supported.
> 
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
>  app/test-pmd/cmdline.c |  9 +++++++--
>  app/test-pmd/config.c  | 32 ++++++++++++++++++++++++++++++++  app/test-
> pmd/testpmd.h |  1 +

There should also be an entry in the following file for this command:
dpdk/doc/guides/testpmd_app_ug/testpmd_funcs.rst

Should there be an entry in the release notes to announce this new testpmd command?


>  3 files changed, 40 insertions(+), 2 deletions(-)
> 

<snip>

Regards,

Bernard.

      reply	other threads:[~2018-10-08 10:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18  8:59 [dpdk-dev] [PATCH v1] testpmd: " Gaetan Rivet
2018-09-18 11:09 ` Gaëtan Rivet
2018-09-21 15:41 ` Ferruh Yigit
2018-09-21 16:13   ` Gaëtan Rivet
2018-09-21 16:49     ` Ferruh Yigit
2018-10-05 21:58 ` [dpdk-dev] [PATCH v2] testpmd: sfp " Gaetan Rivet
2018-10-08 10:36   ` Iremonger, Bernard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CEF83825BEC744B83065625E567D7C260D0DC07@IRSMSX107.ger.corp.intel.com \
    --to=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=gaetan.rivet@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).