From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 423AB1E25 for ; Mon, 8 Oct 2018 12:36:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2018 03:36:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,356,1534834800"; d="scan'208";a="77067734" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga008.fm.intel.com with ESMTP; 08 Oct 2018 03:36:09 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by IRSMSX102.ger.corp.intel.com ([169.254.2.67]) with mapi id 14.03.0319.002; Mon, 8 Oct 2018 11:36:09 +0100 From: "Iremonger, Bernard" To: Gaetan Rivet , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH v2] testpmd: sfp eeprom display Thread-Index: AQHUXPa8rbLDQlbo0EqtSj9flMbwsKUVKSbA Date: Mon, 8 Oct 2018 10:36:08 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D0DC07@IRSMSX107.ger.corp.intel.com> References: <01e0e0ffd6a796a73150588823cf3434aafa7c50.1537261084.git.gaetan.rivet@6wind.com> <8fccc9432769b39d66e909945501ee4a0027f538.1538776598.git.gaetan.rivet@6wind.com> In-Reply-To: <8fccc9432769b39d66e909945501ee4a0027f538.1538776598.git.gaetan.rivet@6wind.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDVkNzVlNGEtODQ5NC00Mjk5LTkwZjEtYTIzMjU2YjMzYzM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicktFVnhqNEV1b0xiMFo4VnVnOTY5TXBWTk11bFwvZkxLTE9pS1VSY2Z0Y0pzYnlSSG4wOXNHcEdRbGN5QWkzYkkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] testpmd: sfp eeprom display X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 10:36:11 -0000 Hi Gaetan > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gaetan Rivet > Sent: Friday, October 5, 2018 10:59 PM > To: dev@dpdk.org > Cc: Gaetan Rivet ; Yigit, Ferruh > > Subject: [dpdk-dev] [PATCH v2] testpmd: sfp eeprom display ./devtools/check-git-log.sh=20 Wrong headline format: myscripts: add setup_dpdk.sh Wrong headline label: testpmd: sfp eeprom display Wrong headline lowercase: testpmd: sfp eeprom display >=20 > The interactive command >=20 > show port sfp_eeprom >=20 > will dump the content of the SFP EEPROM for the selected port. > Dumping SFP eeprom of all ports at once is not supported. >=20 > Signed-off-by: Gaetan Rivet > --- > app/test-pmd/cmdline.c | 9 +++++++-- > app/test-pmd/config.c | 32 ++++++++++++++++++++++++++++++++ app/test- > pmd/testpmd.h | 1 + There should also be an entry in the following file for this command: dpdk/doc/guides/testpmd_app_ug/testpmd_funcs.rst Should there be an entry in the release notes to announce this new testpmd = command? > 3 files changed, 40 insertions(+), 2 deletions(-) >=20 Regards, Bernard.