From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id B85125699 for ; Wed, 17 Oct 2018 12:30:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2018 03:30:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,392,1534834800"; d="scan'208";a="100948436" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga002.jf.intel.com with ESMTP; 17 Oct 2018 03:30:27 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by IRSMSX153.ger.corp.intel.com ([169.254.9.121]) with mapi id 14.03.0319.002; Wed, 17 Oct 2018 11:30:26 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon , Andrew Rybchenko CC: "Yigit, Ferruh" , "dev@dpdk.org" , "ophirmu@mellanox.com" Thread-Topic: [dpdk-dev] [PATCH v3 1/4] app/testpmd: allow detaching a port not closed Thread-Index: AQHUZeKLH0ve6BTf3Ua8Ax0s8pqB8KUjCBUAgAAzNMA= Date: Wed, 17 Oct 2018 10:30:25 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D1268E@IRSMSX107.ger.corp.intel.com> References: <20180907233929.21950-1-thomas@monjalon.net> <20181017015450.15783-2-thomas@monjalon.net> <2356863.vgucDQR85H@xps> In-Reply-To: <2356863.vgucDQR85H@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjYwYmZkNTQtMTdlZi00MDBhLTgzZmUtODA5MzBmZDU1YTQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS3l4RFwvdDlKK2V5RUR2NEswUWZaQW85cnFITGpZZXhzMm9mRE9uNmNIbmNpbWYwemVOSzByUFNxdWJMRWt6dUgifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/4] app/testpmd: allow detaching a port not closed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 10:30:30 -0000 Hi Thomas, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, October 17, 2018 9:21 AM > To: Andrew Rybchenko > Cc: Yigit, Ferruh ; dev@dpdk.org; > ophirmu@mellanox.com > Subject: Re: [dpdk-dev] [PATCH v3 1/4] app/testpmd: allow detaching a por= t not > closed >=20 > 17/10/2018 08:26, Andrew Rybchenko: > > On 10/17/18 4:54 AM, Thomas Monjalon wrote: > > > The testpmd application aim is for testing; so order of operations > > > should not be enforced. > > > > > > There was a test to forbid detaching before closing a port. > > > However, it may interesting to test what happens in such case. > > > It is possible for a PMD to automatically close the port when detachi= ng. > > > > > > Signed-off-by: Thomas Monjalon > > > > I'm afraid it could be a problem which the patch, since port close > > ensures that the port is not used for traffic forwarding. > > Right now the check is gone and we can detach port which is used for > > traffic forwarding on separate data cores. > > So, almost guaranteed crash. >=20 > Yes I can duplicate this check in detach_port(). I agree with Andrew that this will cause a crash. I don't understand why the sequence is changing here. The close(), detach() sequence has been in place since the port hot plug w= ork some years ago, user applications may already be using this sequence. Regards, Bernard. =20