From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A249A4F90 for ; Wed, 17 Oct 2018 18:24:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2018 09:24:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,393,1534834800"; d="scan'208";a="101025767" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga002.jf.intel.com with ESMTP; 17 Oct 2018 09:24:44 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by IRSMSX109.ger.corp.intel.com ([169.254.13.3]) with mapi id 14.03.0319.002; Wed, 17 Oct 2018 17:24:43 +0100 From: "Iremonger, Bernard" To: Raslan Darawsheh , "Wu, Jingjing" CC: "thomas@monjalon.net" , "dev@dpdk.org" , "shahafs@mellanox.com" , "xuemingl@mellanox.com" , "orika@mellanox.com" , "jerin.jacob@caviumnetworks.com" , "david.marchand@6wind.com" , "Yigit, Ferruh" Thread-Topic: [PATCH v6 3/3] app/testpmd: set packet dump based on verbosity level Thread-Index: AQHUZi1BqYJlfD+hlkCye/Ni8EWqAqUjnZuQ Date: Wed, 17 Oct 2018 16:24:42 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D1292F@IRSMSX107.ger.corp.intel.com> References: <1538897848-1693-1-git-send-email-rasland@mellanox.com> <1539789731-18409-1-git-send-email-rasland@mellanox.com> <1539789731-18409-3-git-send-email-rasland@mellanox.com> In-Reply-To: <1539789731-18409-3-git-send-email-rasland@mellanox.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmU2OGM3YTQtMjliYy00NGVjLWE1ODUtN2Y4YzA0YWY0ZjY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSDMycUlWV0hIbjFxOE9GanVnUk42NlFvY1daaCtcL3NUeWZSYTBia1FBeGtuM1VcLzNtZCtBWFVGNDhKZ2xNOHFcLyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 3/3] app/testpmd: set packet dump based on verbosity level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 16:24:48 -0000 Hi Raslan, > -----Original Message----- > From: Raslan Darawsheh [mailto:rasland@mellanox.com] > Sent: Wednesday, October 17, 2018 4:22 PM > To: Wu, Jingjing > Cc: thomas@monjalon.net; dev@dpdk.org; shahafs@mellanox.com; > rasland@mellanox.com; xuemingl@mellanox.com; orika@mellanox.com; > jerin.jacob@caviumnetworks.com; david.marchand@6wind.com; Iremonger, > Bernard ; Yigit, Ferruh > Subject: [PATCH v6 3/3] app/testpmd: set packet dump based on verbosity l= evel >=20 > when changing verbosity level it will configure rx/tx callbacks to dump p= ackets > based on the verbosity value as following: > 1- dump only received packets: > testpmd> set verbose 1 > 2- dump only sent packets: > testpmd> set verbose 2 > 3- dump sent and received packets: > testpmd> set verbose (any number > 2) > 4- disable dump > testpmd> set verbose 0 >=20 > Signed-off-by: Raslan Darawsheh > Acked-by: Bernard Iremonger >=20 > --- > changes in v6: > add documentation for the packet dump > --- > --- > app/test-pmd/config.c | 25 +++++++++++++++++++++++= ++ > app/test-pmd/testpmd.c | 4 ++-- > app/test-pmd/testpmd.h | 1 + > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 +++++- > 4 files changed, 33 insertions(+), 3 deletions(-) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > 55fec7f..1696623 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -50,6 +50,7 @@ > #endif > #include > #include > +#include >=20 > #include "testpmd.h" >=20 > @@ -2773,11 +2774,35 @@ remove_tx_dump_callbacks(portid_t portid) } >=20 > void > +configure_rxtx_dump_callbacks(uint16_t verbose) { > + portid_t portid; > + > +#ifndef RTE_ETHDEV_RXTX_CALLBACKS > + TESTPMD_LOG(ERR, "setting rxtx callbacks is not enabled\n"); > + return; > +#endif > + > + RTE_ETH_FOREACH_DEV(portid) > + { > + if (verbose =3D=3D 1 || verbose > 2) > + add_rx_dump_callbacks(portid); > + else > + remove_rx_dump_callbacks(portid); > + if (verbose >=3D 2) > + add_tx_dump_callbacks(portid); > + else > + remove_tx_dump_callbacks(portid); > + } > +} > + > +void > set_verbose_level(uint16_t vb_level) > { > printf("Change verbose level from %u to %u\n", > (unsigned int) verbose_level, (unsigned int) vb_level); > verbose_level =3D vb_level; > + configure_rxtx_dump_callbacks(verbose_level); > } >=20 > void > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 5dbbf78..3c42924 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1988,7 +1988,7 @@ start_port(portid_t pid) > return -1; > } > } > - > + configure_rxtx_dump_callbacks(0); > printf("Configuring Port %d (socket %u)\n", pi, > port->socket_id); > /* configure port */ > @@ -2087,7 +2087,7 @@ start_port(portid_t pid) > return -1; > } > } > - > + configure_rxtx_dump_callbacks(verbose_level); > /* start port */ > if (rte_eth_dev_start(pi) < 0) { > printf("Fail to start port %d\n", pi); diff --git a/app/test- > pmd/testpmd.h b/app/test-pmd/testpmd.h index c07bee8..3da728c 100644 > --- a/app/test-pmd/testpmd.h > +++ b/app/test-pmd/testpmd.h > @@ -777,6 +777,7 @@ void add_rx_dump_callbacks(portid_t portid); void > remove_rx_dump_callbacks(portid_t portid); void > add_tx_dump_callbacks(portid_t portid); void > remove_tx_dump_callbacks(portid_t portid); > +void configure_rxtx_dump_callbacks(uint16_t verbose); >=20 > /* > * Work-around of a compilation error with ICC on invocations of the dif= f --git > a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index ca060e1..60855c6 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -449,7 +449,11 @@ Set the debug verbosity level:: >=20 > testpmd> set verbose (level) >=20 > -Currently the only available levels are 0 (silent except for error) and = 1 (fully > verbose). > +Available levels are as following: > +* ``0`` silent except for error. > +* ``1`` fully verbose except for Tx packets. > +* ``2`` fully verbose except for Rx packets. > +* ``> 2`` fully verbose. >=20 The html output is probably not what you intended: Available levels are as following: * 0 silent except for error. * 1 fully v= erbose except for Tx packets. * 2 fully verbose except for Rx packets. * > = 2 fully verbose. A blank line is needed between each line. > set log > ~~~~~~~ > -- > 2.7.4 Regards, Bernard.