Re: [dpdk-dev] [PATCH] app/testpmd: support more types for flow RSS

["Iremonger, Bernard" <bernard.iremonger@intel.com>]

Hi Zhao,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> Sent: Monday, October 22, 2018 8:49 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org; Peng, Yuan
> <yuan.peng@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: support more types for flow RSS
> 
> Some user and tester require flow RSS to support more types, so and "all" and

typo in commit message "and "all"  " should be "add "all""

> "none" to make configuration more easy for users.
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>  app/test-pmd/config.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> bf3cd0a..f068da1 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -74,6 +74,10 @@ static const struct {  };
> 
>  const struct rss_type_info rss_type_table[] = {
> +	{ "all", ETH_RSS_IP | ETH_RSS_TCP |
> +			ETH_RSS_UDP | ETH_RSS_SCTP |
> +			ETH_RSS_L2_PAYLOAD },
> +	{ "none", 0 },
>  	{ "ipv4", ETH_RSS_IPV4 },
>  	{ "ipv4-frag", ETH_RSS_FRAG_IPV4 },
>  	{ "ipv4-tcp", ETH_RSS_NONFRAG_IPV4_TCP },
> --
> 2.7.5

The "all" and "none" options are already documented in testpmd.
This looks like a fix, if so should there be a fixes line?

Regards,

Bernard.