From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 494464CA7; Mon, 22 Oct 2018 12:44:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2018 03:44:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,412,1534834800"; d="scan'208";a="80613671" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga008.fm.intel.com with ESMTP; 22 Oct 2018 03:44:37 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 22 Oct 2018 11:44:36 +0100 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by irsmsx112.ger.corp.intel.com ([169.254.1.197]) with mapi id 14.03.0319.002; Mon, 22 Oct 2018 11:44:36 +0100 From: "Iremonger, Bernard" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "stable@dpdk.org" , "Peng, Yuan" , "Zhao1, Wei" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: support more types for flow RSS Thread-Index: AQHUad8py7jsJ+rknUC+P/S3nJzlWKUrE2og Date: Mon, 22 Oct 2018 10:44:35 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D14A10@IRSMSX107.ger.corp.intel.com> References: <1540194565-40052-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1540194565-40052-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzFlOGQwNmEtZDY2Mi00OGQ0LTljNzAtMzIxMzliYTU5YWIzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZEsyV3lJbkVkMFkxZm00WHVQbW9wR1dZY3A4ZTMyZWlsUzdHR0tRU21XVXNpTE04cmlXT0JMaXZIZ0dETUMwUyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support more types for flow RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 10:44:40 -0000 Hi Zhao, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao > Sent: Monday, October 22, 2018 8:49 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; stable@dpdk.org; Peng, Yuan > ; Zhao1, Wei > Subject: [dpdk-dev] [PATCH] app/testpmd: support more types for flow RSS >=20 > Some user and tester require flow RSS to support more types, so and "all"= and typo in commit message "and "all" " should be "add "all"" > "none" to make configuration more easy for users. >=20 > Signed-off-by: Wei Zhao > --- > app/test-pmd/config.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > bf3cd0a..f068da1 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -74,6 +74,10 @@ static const struct { }; >=20 > const struct rss_type_info rss_type_table[] =3D { > + { "all", ETH_RSS_IP | ETH_RSS_TCP | > + ETH_RSS_UDP | ETH_RSS_SCTP | > + ETH_RSS_L2_PAYLOAD }, > + { "none", 0 }, > { "ipv4", ETH_RSS_IPV4 }, > { "ipv4-frag", ETH_RSS_FRAG_IPV4 }, > { "ipv4-tcp", ETH_RSS_NONFRAG_IPV4_TCP }, > -- > 2.7.5 The "all" and "none" options are already documented in testpmd. This looks like a fix, if so should there be a fixes line? Regards, Bernard.