From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 09F291B39A for ; Mon, 22 Oct 2018 17:11:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2018 08:11:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,412,1534834800"; d="scan'208";a="83198247" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga007.jf.intel.com with ESMTP; 22 Oct 2018 08:11:36 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by IRSMSX106.ger.corp.intel.com ([169.254.8.45]) with mapi id 14.03.0319.002; Mon, 22 Oct 2018 16:11:35 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon , "dev@dpdk.org" CC: "gaetan.rivet@6wind.com" , "ophirmu@mellanox.com" , "wisamm@mellanox.com" , "Yigit, Ferruh" , "arybchenko@solarflare.com" Thread-Topic: [PATCH v6 0/7] replace attach/detach functions Thread-Index: AQHUagM8mmErc93xs0uUhFBPuZ7vCKUrXhEQ Date: Mon, 22 Oct 2018 15:11:35 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D14DC6@IRSMSX107.ger.corp.intel.com> References: <20181007222554.4886-1-thomas@monjalon.net> <20181022123110.5733-1-thomas@monjalon.net> In-Reply-To: <20181022123110.5733-1-thomas@monjalon.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWM0YjE4Y2UtYThjYS00ZGU5LWIxZDQtYzYwNzcyYzI3NTU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiblhOQXg1VERhdEczc3BtK1RaWUNDQ1pnMmUzSHJQU0tHQjFPTjdCN2l2VU9oWTM2U0RXaHpWWXNER2NOcWJFRyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 0/7] replace attach/detach functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 15:11:40 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, October 22, 2018 1:31 PM > To: dev@dpdk.org > Cc: gaetan.rivet@6wind.com; ophirmu@mellanox.com; > wisamm@mellanox.com; Yigit, Ferruh ; > arybchenko@solarflare.com; Iremonger, Bernard > > Subject: [PATCH v6 0/7] replace attach/detach functions >=20 > The functions for EAL attach/detach had already some replacements, so the= y > are removed. > The functions for ethdev attach/detach are removed and replaced thanks to= a > new ethdev iterator working with devargs. >=20 > rte_eth_dev_attach(devargs, &port_id) is replaced by: > rte_dev_probe(devargs); > RTE_ETH_FOREACH_MATCHING_DEV(port_id, devargs, &iterator) { > do what you want with the new port_id > } >=20 > The biggest benefit is to be able to manage devargs string matching sever= al > ports to probe. >=20 >=20 > Changes in v6: > - improve testpmd logs > - update testpmd port_status when detaching multiple ports >=20 > Changes in v5: > - check double detach in testpmd >=20 > Changes in v4: > - fix compilation (due to stricter checks in v3) >=20 > Changes in v3 - after Andrew's review: > - coding rules compliance > - stricter checks for snprintf > - rte_eth_iterator_free() becomes rte_eth_iterator_cleanup() > - add rte_eth_iterator_cleanup in .map >=20 > Changes in v2 - after Andrew's review: > - return only 0 or -1 in vdev_dev_match() > - fix freeing of strings in the iterator > - add rte_eth_iterator_free() > - tolerate extra parameters from old syntax > - add more comments > - separate contributing guide patch >=20 >=20 > Thomas Monjalon (7): > bus/vdev: add iteration filter on name > ethdev: add iterator to match devargs input > ethdev: allow iterating with pure class filter > doc: replace doxygen example in contribution guide > ethdev: remove deprecated attach/detach functions > eal: remove deprecated attach/detach functions > app/testpmd: check not detaching device twice >=20 > app/test-pmd/testpmd.c | 43 +++- > doc/guides/contributing/documentation.rst | 15 +- > doc/guides/prog_guide/index.rst | 1 - > .../prog_guide/port_hotplug_framework.rst | 106 --------- > doc/guides/rel_notes/deprecation.rst | 12 - > doc/guides/rel_notes/release_18_11.rst | 12 + > drivers/bus/vdev/vdev_params.c | 19 +- > drivers/net/virtio/virtio_user_ethdev.c | 1 - > lib/librte_eal/common/eal_common_dev.c | 53 ----- > lib/librte_eal/common/include/rte_common.h | 6 + > lib/librte_eal/common/include/rte_dev.h | 27 --- > lib/librte_eal/rte_eal_version.map | 2 - > lib/librte_ethdev/ethdev_private.c | 10 +- > lib/librte_ethdev/ethdev_private.h | 6 + > lib/librte_ethdev/rte_class_eth.c | 9 +- > lib/librte_ethdev/rte_ethdev.c | 223 +++++++++++------- > lib/librte_ethdev/rte_ethdev.h | 110 ++++++--- > lib/librte_ethdev/rte_ethdev_version.map | 5 +- > 18 files changed, 322 insertions(+), 338 deletions(-) delete mode 10064= 4 > doc/guides/prog_guide/port_hotplug_framework.rst >=20 > -- > 2.19.0 Hi Thomas, The following patch fails to apply to the latest master branch, a rebase ma= y be needed. v6-5-7-ethdev-remove-deprecated-attach-detach-functions.patch The remaining two patches of this patch set then fail to apply. Regards, Bernard.