From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E90055F36 for ; Wed, 24 Oct 2018 18:01:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2018 09:01:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,420,1534834800"; d="scan'208";a="100323526" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga004.fm.intel.com with ESMTP; 24 Oct 2018 08:51:00 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Oct 2018 16:50:59 +0100 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by IRSMSX156.ger.corp.intel.com ([169.254.3.178]) with mapi id 14.03.0319.002; Wed, 24 Oct 2018 16:50:59 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon , "Wu, Jingjing" , "Lu, Wenzhuo" CC: "dev@dpdk.org" , "ophirmu@mellanox.com" , "wisamm@mellanox.com" , "Yigit, Ferruh" , "arybchenko@solarflare.com" Thread-Topic: [PATCH 3/5] app/testpmd: check not configuring port twice Thread-Index: AQHUa59Ggt7YLMnMJkuoKtwzeoAg5aUuikYg Date: Wed, 24 Oct 2018 15:50:58 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D16FBF@IRSMSX107.ger.corp.intel.com> References: <20181024134111.26771-1-thomas@monjalon.net> <20181024134111.26771-4-thomas@monjalon.net> In-Reply-To: <20181024134111.26771-4-thomas@monjalon.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTJlNzBiOWQtZDA3ZS00ZmMwLWFkZTUtODBjZDhkYmM2YjA2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibHVwMlNlM0lrVmIwNWJzdEpXSFRhUUxNWHY1dzJRZlY1Ukx2dElVNm5mcFBBXC9XdGN6TWZkdnBleGE1QkZiY2QifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/5] app/testpmd: check not configuring port twice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 16:01:05 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, October 24, 2018 2:41 PM > To: Iremonger, Bernard ; Wu, Jingjing > ; Lu, Wenzhuo > Cc: dev@dpdk.org; ophirmu@mellanox.com; wisamm@mellanox.com; Yigit, > Ferruh ; arybchenko@solarflare.com > Subject: [PATCH 3/5] app/testpmd: check not configuring port twice >=20 > It is possible to request probing of a device twice, and possibly get new= ports for > this device. ./devtools/check-git-log.sh -1 Wrong beginning of commit message: It is possible to request probing of a device twice, > However, the ports which were already probed and setup must not be setup > again. That's why it is checked whether the port is already part of fwd_p= orts_ids > array at the beginning of the function setup_attached_port(). >=20 > Signed-off-by: Thomas Monjalon Otherwise Acked-by: Bernard Iremonger