From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9A7A42BAE for ; Thu, 25 Oct 2018 10:54:37 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 01:54:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,423,1534834800"; d="scan'208";a="94887157" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga003.jf.intel.com with ESMTP; 25 Oct 2018 01:54:35 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.56]) by IRSMSX102.ger.corp.intel.com ([169.254.2.67]) with mapi id 14.03.0319.002; Thu, 25 Oct 2018 09:54:34 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon CC: "Wu, Jingjing" , "Lu, Wenzhuo" , "dev@dpdk.org" , "ophirmu@mellanox.com" , "wisamm@mellanox.com" , "Yigit, Ferruh" , "arybchenko@solarflare.com" Thread-Topic: [PATCH 4/5] app/testpmd: move ethdev events registration Thread-Index: AQHUa59HnwjRTxFTgkOdqBAtPaYNhqUui+XwgAAzD4CAAOlSMA== Date: Thu, 25 Oct 2018 08:54:33 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D172FD@IRSMSX107.ger.corp.intel.com> References: <20181024134111.26771-1-thomas@monjalon.net> <20181024134111.26771-5-thomas@monjalon.net> <8CEF83825BEC744B83065625E567D7C260D16FD4@IRSMSX107.ger.corp.intel.com> <4409048.vUvRZhrQBt@xps> In-Reply-To: <4409048.vUvRZhrQBt@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjQ5MzViNjgtM2ViMS00ZWU2LThkYmEtZmQwMjdhMDJiMjFiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoia2hKaXV5OWRNZG10b3ltTXc5RW5HWmZ3YU1jMm5BZ3d2Qm10SG9EZUlxVDlQQnBEMXNiMWNCeDhNZk1UcjYrOSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/5] app/testpmd: move ethdev events registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 08:54:38 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, October 24, 2018 8:55 PM > To: Iremonger, Bernard > Cc: Wu, Jingjing ; Lu, Wenzhuo > ; dev@dpdk.org; ophirmu@mellanox.com; > wisamm@mellanox.com; Yigit, Ferruh ; > arybchenko@solarflare.com > Subject: Re: [PATCH 4/5] app/testpmd: move ethdev events registration >=20 > 24/10/2018 17:55, Iremonger, Bernard: > > Hi Thomas, > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > +/* Pretty printing of ethdev events */ static const char * const > > > +eth_event_desc[] =3D { > > > + [RTE_ETH_EVENT_UNKNOWN] =3D "unknown", > > > + [RTE_ETH_EVENT_INTR_LSC] =3D "LSC", > > > > How about replacing "LSC" with "interrupt link status change" >=20 > When it is printed, "event" is appended. > So I think "interrupt" is a bit too much. > OK for "link state change"? Yes, =20 > > > + [RTE_ETH_EVENT_QUEUE_STATE] =3D "queue state", > > > + [RTE_ETH_EVENT_INTR_RESET] =3D "interrupt reset", Should "interrupt" be dropped from "interrupt reset" too for consistency?=20 > > > + [RTE_ETH_EVENT_VF_MBOX] =3D "VF mbox", > > > + [RTE_ETH_EVENT_IPSEC] =3D "IPsec", > > > + [RTE_ETH_EVENT_MACSEC] =3D "MACsec", > > > + [RTE_ETH_EVENT_INTR_RMV] =3D "device removal", > > > > How about replacing "device removal" with "interrupt device removal" >=20 > For same reason, I think "device removal" is enough. > It will be printed as "device removal event". >=20 >=20 Regards, Bernard.