From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 9E7155F62; Thu, 3 Jan 2019 14:49:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2019 05:49:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,435,1539673200"; d="scan'208";a="106678072" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga008.jf.intel.com with ESMTP; 03 Jan 2019 05:49:32 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 3 Jan 2019 13:49:10 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.205]) by irsmsx111.ger.corp.intel.com ([169.254.2.160]) with mapi id 14.03.0415.000; Thu, 3 Jan 2019 13:49:10 +0000 From: "Iremonger, Bernard" To: Rami Rosen , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] doc: fix a parameter name in testpmd guide Thread-Index: AQHUnFbu8SIgTya0G0m0kY/ieRPd/qWdmVxg Date: Thu, 3 Jan 2019 13:49:09 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D48F3C@IRSMSX108.ger.corp.intel.com> References: <1545745000-114010-1-git-send-email-ramirose@gmail.com> In-Reply-To: <1545745000-114010-1-git-send-email-ramirose@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmQwNjVjZGYtZTA2NS00YTU3LTgxN2MtZjYzN2QxNzgwMjRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieTBDUGpxcHRaamY1c1FoSTBzSmZBYWNuU2kraHg4OGdlZ3JYaEtPSDhrbjRDMjNVQnFrWTZJVFFBdnlsRGlWXC8ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: fix a parameter name in testpmd guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 13:49:35 -0000 Hi Rami, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rami Rosen > Sent: Tuesday, December 25, 2018 1:37 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Rami Rosen > Subject: [dpdk-dev] [PATCH] doc: fix a parameter name in testpmd guide >=20 > There is no parameter called "eth-peer-configfile" in testpmd. It should = be > "eth-peers-configfile". See the usage() method in app/test- > pmd/parameters.c. >=20 > Fixes: a67857e97ba8 ("doc: clarify usage of testpmd MAC forward mode") > Cc: stable@dpdk.org >=20 > Signed-off-by: Rami Rosen > --- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index cbf23e9..1ceb000 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -304,7 +304,7 @@ The available information categories are: > * ``mac``: Changes the source and the destination Ethernet addresses of > packets before forwarding them. > Default application behaviour is to set source Ethernet address to tha= t of > the transmitting interface, and destination > address to a dummy value (set during init). The user may specify a tar= get > destination Ethernet address via the 'eth-peer' or > - 'eth-peer-configfile' command-line options. It is not currently possib= le to > specify a specific source Ethernet address. > + 'eth-peers-configfile' command-line options. It is not currently possi= ble to > specify a specific source Ethernet address. >=20 > * ``macswap``: MAC swap forwarding mode. > Swaps the source and the destination Ethernet addresses of packets > before forwarding them. > -- > 1.8.3.1 ./dpdk/devtools/check-git-log.sh -1 Line too long: "eth-peers-configfile". See the usage() method in app/test-pmd/para= meters.c. ./dpdk/devtools/checkpatches.sh /home/bairemon/patches_19_02_rc1_patchwork_= testpmd/doc-fix-a-parameter-name-in-testpmd-guide.patch ### doc: fix a parameter name in testpmd guide WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer= a maximum 75 chars per line) #18:=20 There is no parameter called "eth-peer-configfile" in testpmd. It should be= =20 total: 0 errors, 1 warnings, 8 lines checked The above warnings should be fixed. Regards, Bernard.