From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 3D5C51B49D; Fri, 4 Jan 2019 14:48:03 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jan 2019 05:48:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,439,1539673200"; d="scan'208";a="106954481" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga008.jf.intel.com with ESMTP; 04 Jan 2019 05:48:01 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by irsmsx105.ger.corp.intel.com (163.33.3.28) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 4 Jan 2019 13:48:01 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.205]) by irsmsx111.ger.corp.intel.com ([169.254.2.160]) with mapi id 14.03.0415.000; Fri, 4 Jan 2019 13:48:00 +0000 From: "Iremonger, Bernard" To: "Dumitrescu, Cristian" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Wu, Jingjing" , "stable@dpdk.org" Thread-Topic: [PATCH v2] app/testpmd: fix quit to stop all ports before close Thread-Index: AQHUpCkKm13T+CIDnEmA2LYPxFUvqqWfH5RA Date: Fri, 4 Jan 2019 13:47:59 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D4A3DD@IRSMSX108.ger.corp.intel.com> References: <20190104122833.49245-1-cristian.dumitrescu@intel.com> In-Reply-To: <20190104122833.49245-1-cristian.dumitrescu@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGJhYzQzZTAtOTY2OS00YTUzLWFlNTEtMDliOTdlNThkYTA1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMlJPSVBxWmdYellOdmhtcGJ3d21BaTUxQ3FDOHQwbjkrd2JabERtdHY1UU9DamdTaDJQdVp3azd6dzVmYjhaZSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix quit to stop all ports before close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 13:48:05 -0000 > -----Original Message----- > From: Dumitrescu, Cristian > Sent: Friday, January 4, 2019 12:29 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard = ; > stable@dpdk.org > Subject: [PATCH v2] app/testpmd: fix quit to stop all ports before close >=20 > This patch proposes a slightly different test-pmd quit operation: stop al= l devices > before starting to close any device. Basically, stop all moving parts bef= ore > beginning to remove them. The current test-pmd quit is stopping and closi= ng > each device before moving to the next device. >=20 > If all devices in the system are independent of each other, this differen= ce is > usually not important. In case of Soft NIC devices, any such virtual devi= ce > typically depends on one or more physical devices being alive, as it acce= sses > their queues, so this difference becomes important. >=20 > Without this straightforward fix, all the Soft NIC devices need to be man= ually > stopped before the quit command is issued, otherwise the quit command can > sometimes crash the test-pmd application. >=20 > Fixes: d3a274ce9dee ("app/testpmd: handle SIGINT and SIGTERM") > Cc: stable@dpdk.org >=20 > Signed-off-by: Cristian Dumitrescu Acked-by: Bernard Iremonger