From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id CD7FD5592; Mon, 14 Jan 2019 14:39:27 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2019 05:39:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,477,1539673200"; d="scan'208";a="106460806" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga007.jf.intel.com with ESMTP; 14 Jan 2019 05:39:25 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.205]) by IRSMSX153.ger.corp.intel.com ([169.254.9.115]) with mapi id 14.03.0415.000; Mon, 14 Jan 2019 13:39:25 +0000 From: "Iremonger, Bernard" To: Yongseok Koh , "Lu, Wenzhuo" , "Wu, Jingjing" CC: "dev@dpdk.org" , "Zhang, Qi Z" , "stable@dpdk.org" Thread-Topic: [PATCH 1/2] app/testpmd: fix wrong pointer reference in macswap Thread-Index: AQHUq/AbraFzzxyBYUO+P7zMULB1XKWuxPWg Date: Mon, 14 Jan 2019 13:39:24 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D4E569@IRSMSX108.ger.corp.intel.com> References: <20190114100022.14867-1-yskoh@mellanox.com> In-Reply-To: <20190114100022.14867-1-yskoh@mellanox.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjI1ODBlOGMtMGJmZS00MWI1LWE4NDItZWY2NzBkODFhYTI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoic0J0SVdNSml2OEVyXC92R1wvYUNkaTRzMXdMektBNml0aEEzVk5oazVhTEZENGxsR1JqTGk3bmlreENZTlEyU1cwIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix wrong pointer reference in macswap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 13:39:28 -0000 > -----Original Message----- > From: Yongseok Koh [mailto:yskoh@mellanox.com] > Sent: Monday, January 14, 2019 10:00 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > Cc: dev@dpdk.org; Zhang, Qi Z ; stable@dpdk.org > Subject: [PATCH 1/2] app/testpmd: fix wrong pointer reference in macswap >=20 > The pointer is misused and could set wrong MAC address. As a result, some= of > packets can be dropped in receiver side due to MAC address mismatch. > This can be shown as performance degradation. >=20 > Bugzilla ID: 188 >=20 > Fixes: 62b52877adbe ("app/testpmd: batch MAC swap for performance on x86"= ) > Cc: qi.z.zhang@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Yongseok Koh Acked-by: Bernard Iremonger