DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Rami Rosen <ramirose@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: add missing loopback option in testpmd guide
Date: Thu, 17 Jan 2019 10:54:47 +0000	[thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260D4F864@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1547717473-7213-1-git-send-email-ramirose@gmail.com>

Hi Rami

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rami Rosen
> Sent: Thursday, January 17, 2019 9:31 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Rami
> Rosen <ramirose@gmail.com>
> Subject: [dpdk-dev] [PATCH] doc: add missing loopback option in testpmd guide
> 
> This patch adds a missing topology loopback mode for port-topology option in
> testpmd guide. The testpmd loopback option
> (PORT_TOPOLOGY_LOOP)  was added to testpmd parameter port-topology back
> in 2014, but it seems that it was never added to the testpmd guide. This patch
> adds it in the testpmd guide.
> 
> Fixes: 3e2006d6186c ("app/testpmd: add loopback topology")
> Cc: stable@dpdk.org
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>  doc/guides/testpmd_app_ug/run_app.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/testpmd_app_ug/run_app.rst
> b/doc/guides/testpmd_app_ug/run_app.rst
> index f717bd3..ee51b1d 100644
> --- a/doc/guides/testpmd_app_ug/run_app.rst
> +++ b/doc/guides/testpmd_app_ug/run_app.rst
> @@ -196,7 +196,7 @@ The commandline options are:
> 
>  *   ``--port-topology=mode``
> 
> -    Set port topology, where mode is ``paired`` (the default) or ``chained``.
> +    Set port topology, where mode is ``paired`` (the default), ``chained`` or
> ``loopback``.

In the C code (app/test-pmd/parameters.c) "loop" is used instead of "loopback".
The run_app.rst file should use "loop" as well.
 
>      In ``paired`` mode, the forwarding is between pairs of ports, for example:
> (0,1), (2,3), (4,5).
> 
> @@ -204,6 +204,8 @@ The commandline options are:
> 
>      The ordering of the ports can be changed using the portlist testpmd runtime
> function.
> 
> +    In ``loopback`` mode, ingress traffic is simply transmitted back on the same
> interface.
> +
>  *   ``--forward-mode=mode``
> 
>      Set the forwarding mode where ``mode`` is one of the following::
> --
> 1.8.3.1

Regards,

Bernard.

      reply	other threads:[~2019-01-17 10:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17  9:31 Rami Rosen
2019-01-17 10:54 ` Iremonger, Bernard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CEF83825BEC744B83065625E567D7C260D4F864@IRSMSX108.ger.corp.intel.com \
    --to=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=ramirose@gmail.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).