From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 313554C99 for ; Thu, 17 Jan 2019 12:12:40 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2019 03:12:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,488,1539673200"; d="scan'208";a="135420809" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga002.fm.intel.com with ESMTP; 17 Jan 2019 03:12:38 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.205]) by IRSMSX107.ger.corp.intel.com ([169.254.10.127]) with mapi id 14.03.0415.000; Thu, 17 Jan 2019 11:12:37 +0000 From: "Iremonger, Bernard" To: "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [PATCH] test/ipsec: fix test suite setup function Thread-Index: AQHUrMRN9oocfroEVE6xehvRY826pqWwOPqAgAABXvCAAA2hgIAB2O0AgAEk1oCAAAoVsA== Date: Thu, 17 Jan 2019 11:12:36 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D4F8B3@IRSMSX108.ger.corp.intel.com> References: <1547551191-28863-1-git-send-email-bernard.iremonger@intel.com> <2601191342CEEE43887BDE71AB977258010D90422F@irsmsx105.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C260D4ECBD@IRSMSX108.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258010D904263@irsmsx105.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C260D4F7FD@IRSMSX108.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258010D904F1F@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258010D904F1F@irsmsx105.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjFhNjIyMWMtNDBkYS00YWNjLWI2OTEtZTNmNzE1YTZmNzgyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYnJVeXBMNXVWRjQ3Mmp5UGpkd3d1YSt3QU9EVmpOclpad3RCS3EyK1dLcjZEYUthYitSQlR6MFpmelM4Y05hNCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test/ipsec: fix test suite setup function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 11:12:40 -0000 Hi Konstantin, > > > > > I think you need to check driver capabilities, instead of > > > > > relying on driver > > > name. > > > > > > > > I don't think it is necessary to check the driver capabilities. > > > > > > I still think that the valid way to check supported algorithms is to > > > check device capabilities, not the driver name. > > > > In the testsuite_setup() function the parameters for the > > check_cryptodev_capability() are not setup. They are setup in the test > functions of the testsuite. >=20 > Ok, so what prevents us to setup them earlier? This will require some refactoring of the tests, I will investigate. > > As discussed offline it should be sufficient to test with the crypto_de= v NULL > PMD. >=20 > As we discussed offline - yes, I don't think it's too excessive to verif= y > ipsec_autotest with each existing driver that supports _NULL algs, but I = don't > see the reason why it shouldn't support anything except crypto_null. > Konstantin Ok, I will investigate what needs to be done. Regards, Bernard.