* [dpdk-dev] [PATCH] app/testpmd: fix stdout flush absence after printing stats
@ 2019-03-18 11:35 Andrew Rybchenko
2019-03-18 11:35 ` Andrew Rybchenko
2019-03-20 13:21 ` Iremonger, Bernard
0 siblings, 2 replies; 6+ messages in thread
From: Andrew Rybchenko @ 2019-03-18 11:35 UTC (permalink / raw)
To: Wenzhuo Lu, Jingjing Wu, Bernard Iremonger; +Cc: dev, Igor Romanov, stable
From: Igor Romanov <igor.romanov@oktetlabs.ru>
User can specify stats period(n). The statistics should be available
to user every n second. But the print_stats() function does not
force stdout to be flushed, so for instance, a user reading testpmd's
stdout through pipe will not be able to read it untill the stdout
buffer is filled.
Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically")
Cc: stable@dpdk.org
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
app/test-pmd/testpmd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index d9d0c16d4..216be47f9 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3046,6 +3046,8 @@ print_stats(void)
printf("\nPort statistics ====================================");
for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++)
nic_stats_display(fwd_ports_ids[i]);
+
+ fflush(stdout);
}
static void
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH] app/testpmd: fix stdout flush absence after printing stats
2019-03-18 11:35 [dpdk-dev] [PATCH] app/testpmd: fix stdout flush absence after printing stats Andrew Rybchenko
@ 2019-03-18 11:35 ` Andrew Rybchenko
2019-03-20 13:21 ` Iremonger, Bernard
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Rybchenko @ 2019-03-18 11:35 UTC (permalink / raw)
To: Wenzhuo Lu, Jingjing Wu, Bernard Iremonger; +Cc: dev, Igor Romanov, stable
From: Igor Romanov <igor.romanov@oktetlabs.ru>
User can specify stats period(n). The statistics should be available
to user every n second. But the print_stats() function does not
force stdout to be flushed, so for instance, a user reading testpmd's
stdout through pipe will not be able to read it untill the stdout
buffer is filled.
Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically")
Cc: stable@dpdk.org
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
app/test-pmd/testpmd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index d9d0c16d4..216be47f9 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3046,6 +3046,8 @@ print_stats(void)
printf("\nPort statistics ====================================");
for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++)
nic_stats_display(fwd_ports_ids[i]);
+
+ fflush(stdout);
}
static void
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix stdout flush absence after printing stats
2019-03-18 11:35 [dpdk-dev] [PATCH] app/testpmd: fix stdout flush absence after printing stats Andrew Rybchenko
2019-03-18 11:35 ` Andrew Rybchenko
@ 2019-03-20 13:21 ` Iremonger, Bernard
2019-03-20 13:21 ` Iremonger, Bernard
2019-03-20 20:13 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
1 sibling, 2 replies; 6+ messages in thread
From: Iremonger, Bernard @ 2019-03-20 13:21 UTC (permalink / raw)
To: Andrew Rybchenko, Lu, Wenzhuo, Wu, Jingjing; +Cc: dev, Igor Romanov, stable
Hi Andrew,
> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
> Sent: Monday, March 18, 2019 11:36 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Igor Romanov <igor.romanov@oktetlabs.ru>;
> stable@dpdk.org
> Subject: [PATCH] app/testpmd: fix stdout flush absence after printing stats
>
> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>
> User can specify stats period(n). The statistics should be available to user
> every n second. But the print_stats() function does not force stdout to be
> flushed, so for instance, a user reading testpmd's stdout through pipe will
> not be able to read it untill the stdout buffer is filled.
>
> Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically")
> Cc: stable@dpdk.org
>
> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> app/test-pmd/testpmd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> d9d0c16d4..216be47f9 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3046,6 +3046,8 @@ print_stats(void)
> printf("\nPort statistics
> ====================================");
> for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++)
> nic_stats_display(fwd_ports_ids[i]);
> +
> + fflush(stdout);
> }
>
> static void
> --
> 2.17.1
There is a checkpatch warning on the commit messge.
WARNING:TYPO_SPELLING: 'untill' may be misspelled - perhaps 'until'?
Otherwise
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix stdout flush absence after printing stats
2019-03-20 13:21 ` Iremonger, Bernard
@ 2019-03-20 13:21 ` Iremonger, Bernard
2019-03-20 20:13 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
1 sibling, 0 replies; 6+ messages in thread
From: Iremonger, Bernard @ 2019-03-20 13:21 UTC (permalink / raw)
To: Andrew Rybchenko, Lu, Wenzhuo, Wu, Jingjing; +Cc: dev, Igor Romanov, stable
Hi Andrew,
> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
> Sent: Monday, March 18, 2019 11:36 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Igor Romanov <igor.romanov@oktetlabs.ru>;
> stable@dpdk.org
> Subject: [PATCH] app/testpmd: fix stdout flush absence after printing stats
>
> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>
> User can specify stats period(n). The statistics should be available to user
> every n second. But the print_stats() function does not force stdout to be
> flushed, so for instance, a user reading testpmd's stdout through pipe will
> not be able to read it untill the stdout buffer is filled.
>
> Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically")
> Cc: stable@dpdk.org
>
> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> app/test-pmd/testpmd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> d9d0c16d4..216be47f9 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3046,6 +3046,8 @@ print_stats(void)
> printf("\nPort statistics
> ====================================");
> for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++)
> nic_stats_display(fwd_ports_ids[i]);
> +
> + fflush(stdout);
> }
>
> static void
> --
> 2.17.1
There is a checkpatch warning on the commit messge.
WARNING:TYPO_SPELLING: 'untill' may be misspelled - perhaps 'until'?
Otherwise
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix stdout flush absence after printing stats
2019-03-20 13:21 ` Iremonger, Bernard
2019-03-20 13:21 ` Iremonger, Bernard
@ 2019-03-20 20:13 ` Ferruh Yigit
2019-03-20 20:13 ` Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2019-03-20 20:13 UTC (permalink / raw)
To: Iremonger, Bernard, Andrew Rybchenko, Lu, Wenzhuo, Wu, Jingjing
Cc: dev, Igor Romanov, stable
On 3/20/2019 1:21 PM, Iremonger, Bernard wrote:
> Hi Andrew,
>
>> -----Original Message-----
>> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
>> Sent: Monday, March 18, 2019 11:36 AM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>; Iremonger, Bernard
>> <bernard.iremonger@intel.com>
>> Cc: dev@dpdk.org; Igor Romanov <igor.romanov@oktetlabs.ru>;
>> stable@dpdk.org
>> Subject: [PATCH] app/testpmd: fix stdout flush absence after printing stats
>>
>> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>>
>> User can specify stats period(n). The statistics should be available to user
>> every n second. But the print_stats() function does not force stdout to be
>> flushed, so for instance, a user reading testpmd's stdout through pipe will
>> not be able to read it untill the stdout buffer is filled.
>>
>> Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> There is a checkpatch warning on the commit messge.
> WARNING:TYPO_SPELLING: 'untill' may be misspelled - perhaps 'until'?
>
> Otherwise
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com
>
Applied to dpdk-next-net/master, thanks.
(warning fixed while merging)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix stdout flush absence after printing stats
2019-03-20 20:13 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2019-03-20 20:13 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2019-03-20 20:13 UTC (permalink / raw)
To: Iremonger, Bernard, Andrew Rybchenko, Lu, Wenzhuo, Wu, Jingjing
Cc: dev, Igor Romanov, stable
On 3/20/2019 1:21 PM, Iremonger, Bernard wrote:
> Hi Andrew,
>
>> -----Original Message-----
>> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
>> Sent: Monday, March 18, 2019 11:36 AM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>; Iremonger, Bernard
>> <bernard.iremonger@intel.com>
>> Cc: dev@dpdk.org; Igor Romanov <igor.romanov@oktetlabs.ru>;
>> stable@dpdk.org
>> Subject: [PATCH] app/testpmd: fix stdout flush absence after printing stats
>>
>> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>>
>> User can specify stats period(n). The statistics should be available to user
>> every n second. But the print_stats() function does not force stdout to be
>> flushed, so for instance, a user reading testpmd's stdout through pipe will
>> not be able to read it untill the stdout buffer is filled.
>>
>> Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> There is a checkpatch warning on the commit messge.
> WARNING:TYPO_SPELLING: 'untill' may be misspelled - perhaps 'until'?
>
> Otherwise
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com
>
Applied to dpdk-next-net/master, thanks.
(warning fixed while merging)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-20 20:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-18 11:35 [dpdk-dev] [PATCH] app/testpmd: fix stdout flush absence after printing stats Andrew Rybchenko
2019-03-18 11:35 ` Andrew Rybchenko
2019-03-20 13:21 ` Iremonger, Bernard
2019-03-20 13:21 ` Iremonger, Bernard
2019-03-20 20:13 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-03-20 20:13 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).