From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7AA341B444 for ; Tue, 26 Mar 2019 17:59:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 09:59:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,273,1549958400"; d="scan'208";a="137443251" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga003.jf.intel.com with ESMTP; 26 Mar 2019 09:59:17 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.7]) by irsmsx110.ger.corp.intel.com ([169.254.15.102]) with mapi id 14.03.0415.000; Tue, 26 Mar 2019 16:59:17 +0000 From: "Iremonger, Bernard" To: Natanael Copa , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 01/15] app/testpmd: replace uint with unsigned int Thread-Index: AQHU2b9TEWhAyGxh+UO7/D3bR27fr6YeMzGw Date: Tue, 26 Mar 2019 16:59:16 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D7693A@IRSMSX108.ger.corp.intel.com> References: <20190313170657.16688-1-ncopa@alpinelinux.org> <20190313170657.16688-2-ncopa@alpinelinux.org> In-Reply-To: <20190313170657.16688-2-ncopa@alpinelinux.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTY4MjIzNDgtZTg0Ny00OWUzLWI0YjMtZWI4NDA3OWQwOTk2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibHpZV21PdzdMMHZmT3lWeExlWGZ1MzRBdnFXWGpXa3dwaXRKNXhJNnpaMnhcL1dEYTVwSkxGOUorcTNGUFlOZWgifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 01/15] app/testpmd: replace uint with unsigned int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Mar 2019 16:59:21 -0000 Hi Nataneal, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Natanael Copa > Sent: Wednesday, March 13, 2019 5:07 PM > To: dev@dpdk.org > Cc: Natanael Copa > Subject: [dpdk-dev] [PATCH v3 01/15] app/testpmd: replace uint with > unsigned int This should have the fix keyword in the commit line and a fixes line should= be added. Suggest something like the following: " app/testpmd: fix build error with musl libc" =20 > Improve portability by avoid use non-standard 'uint'. >=20 > This fixes following build error when building with musl libc: >=20 > In file included from ../app/test-pmd/cmdline.c:75: > ../app/test-pmd/testpmd.h:809:29: error: unknown type name 'uint'; did yo= u > mean 'int'? > uint8_t *hash_key, uint hash_key_len); > ^~~~ > int >=20 ./dpdk /devtools/check-git-log.sh -1 Line too long: ../app/test-pmd/testpmd.h:809:29: error: unknown type name 'uint'; = did you mean 'int'? Wrong tag: This fixes following build error when building with musl libc: Need to wrap the compile error message to pass the check-git-log.sh checks. > Signed-off-by: Natanael Copa > --- > app/test-pmd/testpmd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index > fa4887853..84ef3fc30 100644 > --- a/app/test-pmd/testpmd.h > +++ b/app/test-pmd/testpmd.h > @@ -806,7 +806,7 @@ int set_vf_rate_limit(portid_t port_id, uint16_t vf, > uint16_t rate, >=20 > void port_rss_hash_conf_show(portid_t port_id, int show_rss_key); void > port_rss_hash_key_update(portid_t port_id, char rss_type[], > - uint8_t *hash_key, uint hash_key_len); uint should be replaced by uint8_t instead of unsigned int. The rss_key_len is a uint8_t type. > + uint8_t *hash_key, unsigned int hash_key_len); > int rx_queue_id_is_invalid(queueid_t rxq_id); int > tx_queue_id_is_invalid(queueid_t txq_id); void setup_gro(const char > *onoff, portid_t port_id); > -- > 2.21.0 Regards, Bernard. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0525DA05D3 for ; Tue, 26 Mar 2019 17:59:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B64CF1B445; Tue, 26 Mar 2019 17:59:21 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7AA341B444 for ; Tue, 26 Mar 2019 17:59:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 09:59:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,273,1549958400"; d="scan'208";a="137443251" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga003.jf.intel.com with ESMTP; 26 Mar 2019 09:59:17 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.7]) by irsmsx110.ger.corp.intel.com ([169.254.15.102]) with mapi id 14.03.0415.000; Tue, 26 Mar 2019 16:59:17 +0000 From: "Iremonger, Bernard" To: Natanael Copa , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 01/15] app/testpmd: replace uint with unsigned int Thread-Index: AQHU2b9TEWhAyGxh+UO7/D3bR27fr6YeMzGw Date: Tue, 26 Mar 2019 16:59:16 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D7693A@IRSMSX108.ger.corp.intel.com> References: <20190313170657.16688-1-ncopa@alpinelinux.org> <20190313170657.16688-2-ncopa@alpinelinux.org> In-Reply-To: <20190313170657.16688-2-ncopa@alpinelinux.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTY4MjIzNDgtZTg0Ny00OWUzLWI0YjMtZWI4NDA3OWQwOTk2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibHpZV21PdzdMMHZmT3lWeExlWGZ1MzRBdnFXWGpXa3dwaXRKNXhJNnpaMnhcL1dEYTVwSkxGOUorcTNGUFlOZWgifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 01/15] app/testpmd: replace uint with unsigned int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326165916.D7-K5760hgP8X92v6GD7NIHxmIyPhswuVIoVYr7g94I@z> Hi Nataneal, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Natanael Copa > Sent: Wednesday, March 13, 2019 5:07 PM > To: dev@dpdk.org > Cc: Natanael Copa > Subject: [dpdk-dev] [PATCH v3 01/15] app/testpmd: replace uint with > unsigned int This should have the fix keyword in the commit line and a fixes line should= be added. Suggest something like the following: " app/testpmd: fix build error with musl libc" =20 > Improve portability by avoid use non-standard 'uint'. >=20 > This fixes following build error when building with musl libc: >=20 > In file included from ../app/test-pmd/cmdline.c:75: > ../app/test-pmd/testpmd.h:809:29: error: unknown type name 'uint'; did yo= u > mean 'int'? > uint8_t *hash_key, uint hash_key_len); > ^~~~ > int >=20 ./dpdk /devtools/check-git-log.sh -1 Line too long: ../app/test-pmd/testpmd.h:809:29: error: unknown type name 'uint'; = did you mean 'int'? Wrong tag: This fixes following build error when building with musl libc: Need to wrap the compile error message to pass the check-git-log.sh checks. > Signed-off-by: Natanael Copa > --- > app/test-pmd/testpmd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index > fa4887853..84ef3fc30 100644 > --- a/app/test-pmd/testpmd.h > +++ b/app/test-pmd/testpmd.h > @@ -806,7 +806,7 @@ int set_vf_rate_limit(portid_t port_id, uint16_t vf, > uint16_t rate, >=20 > void port_rss_hash_conf_show(portid_t port_id, int show_rss_key); void > port_rss_hash_key_update(portid_t port_id, char rss_type[], > - uint8_t *hash_key, uint hash_key_len); uint should be replaced by uint8_t instead of unsigned int. The rss_key_len is a uint8_t type. > + uint8_t *hash_key, unsigned int hash_key_len); > int rx_queue_id_is_invalid(queueid_t rxq_id); int > tx_queue_id_is_invalid(queueid_t txq_id); void setup_gro(const char > *onoff, portid_t port_id); > -- > 2.21.0 Regards, Bernard.