From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0D3DD1B13C for ; Thu, 28 Mar 2019 11:49:26 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 03:49:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,280,1549958400"; d="scan'208";a="311113565" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga005.jf.intel.com with ESMTP; 28 Mar 2019 03:49:25 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.7]) by IRSMSX107.ger.corp.intel.com ([169.254.10.15]) with mapi id 14.03.0415.000; Thu, 28 Mar 2019 10:49:24 +0000 From: "Iremonger, Bernard" To: "Iremonger, Bernard" , "Yang, Qiming" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Yang, Qiming" Thread-Topic: [dpdk-dev] [PATCH v4 4/5] app/testpmd: add VXLAN-GPE to tunnel type Thread-Index: AQHU3jQ67b6jnjjHX0+jebwtnZhlVKYfVElAgAGWWyA= Date: Thu, 28 Mar 2019 10:49:23 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D77675@IRSMSX108.ger.corp.intel.com> References: <20190318154200.28409-1-qiming.yang@intel.com> <20190319163658.115513-1-qiming.yang@intel.com> <20190319163658.115513-5-qiming.yang@intel.com> <8CEF83825BEC744B83065625E567D7C260D76F15@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D76F15@IRSMSX108.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDA1YjRlYTctOTg5OS00N2VlLWFhYWUtYmM1OWUyOGMzY2Y2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYVczTm1qWCtQRXIzbTgrZlEzWDVSZnl6Nlh2bDZRc1djRnVTMUVWeHZHbENmTDZsb1wvdUc2THZkbWZLRUE2NjYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 4/5] app/testpmd: add VXLAN-GPE to tunnel type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2019 10:49:27 -0000 Hi Qiming, > > Subject: [dpdk-dev] [PATCH v4 4/5] app/testpmd: add VXLAN-GPE to > > tunnel type > > > > This patch added new item "vxlan-gpe" to tunnel_type to support new > > VXLAN-GPE packet type, and its clasification. > > > > Signed-off-by: Qiming Yang > > --- > > app/test-pmd/cmdline.c | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > db53cc0..08a554c 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -8710,6 +8710,8 @@ cmd_tunnel_filter_parsed(void *parsed_result, > > > > if (!strcmp(res->tunnel_type, "vxlan")) > > tunnel_filter_conf.tunnel_type =3D > > RTE_TUNNEL_TYPE_VXLAN; > > + else if (!strcmp(res->tunnel_type, "vxlan-gpe")) > > + tunnel_filter_conf.tunnel_type =3D > > RTE_TUNNEL_TYPE_VXLAN_GPE; > > else if (!strcmp(res->tunnel_type, "nvgre")) > > tunnel_filter_conf.tunnel_type =3D > > RTE_TUNNEL_TYPE_NVGRE; > > else if (!strcmp(res->tunnel_type, "ipingre")) @@ -8759,7 +8761,7 > @@ > > cmdline_parse_token_ipaddr_t cmd_tunnel_filter_ip_value =3D > > ip_value); > > cmdline_parse_token_string_t cmd_tunnel_filter_tunnel_type =3D > > TOKEN_STRING_INITIALIZER(struct cmd_tunnel_filter_result, > > - tunnel_type, "vxlan#nvgre#ipingre"); > > + tunnel_type, "vxlan#nvgre#ipingre#vxlan-gpe"); > > > > cmdline_parse_token_string_t cmd_tunnel_filter_filter_type =3D > > TOKEN_STRING_INITIALIZER(struct cmd_tunnel_filter_result, @@ - > > 8883,6 +8885,8 @@ cmd_cfg_tunnel_udp_port_parsed(void > *parsed_result, > > tunnel_udp.prot_type =3D RTE_TUNNEL_TYPE_VXLAN; > > } else if (!strcmp(res->tunnel_type, "geneve")) { > > tunnel_udp.prot_type =3D RTE_TUNNEL_TYPE_GENEVE; > > + } else if (!strcmp(res->tunnel_type, "vxlan-gpe")) { > > + tunnel_udp.prot_type =3D RTE_TUNNEL_TYPE_VXLAN_GPE; > > } else { > > printf("Invalid tunnel type\n"); > > return; > > @@ -8917,7 +8921,7 @@ cmdline_parse_token_string_t > > cmd_config_tunnel_udp_port_action =3D > > "add#rm"); > > cmdline_parse_token_string_t > cmd_config_tunnel_udp_port_tunnel_type > > =3D > > TOKEN_STRING_INITIALIZER(struct cmd_config_tunnel_udp_port, > > tunnel_type, > > - "vxlan#geneve"); > > + "vxlan#geneve#vxlan-gpe"); > > cmdline_parse_token_num_t cmd_config_tunnel_udp_port_value =3D > > TOKEN_NUM_INITIALIZER(struct cmd_config_tunnel_udp_port, > udp_port, > > UINT16); > > @@ -8925,7 +8929,7 @@ cmdline_parse_token_num_t > > cmd_config_tunnel_udp_port_value =3D cmdline_parse_inst_t > > cmd_cfg_tunnel_udp_port =3D { > > .f =3D cmd_cfg_tunnel_udp_port_parsed, > > .data =3D NULL, > > - .help_str =3D "port config udp_tunnel_port add|rm > > vxlan|geneve ", > > + .help_str =3D "port config udp_tunnel_port add|rm > > +vxlan|geneve|vxlan-gpe ", > > .tokens =3D { > > (void *)&cmd_config_tunnel_udp_port_port, > > (void *)&cmd_config_tunnel_udp_port_config, > > -- > > 2.9.5 >=20 > Should the help strings at lines 374, 378 , 861 in cmdline.c be updated f= or > vxlan-gpe? > Should the help string at lines 2188, 8779 in cmdline.c be updated for v= xlan- > gpe? >=20 > The function flowtype_to_str() at line 11922 should be updated for for > vxlan-gpe. >=20 > There should also be an update in doc/guides/tesptpmd_app_ug/*.rst for > vxlan-gpe. >=20 > Regards, >=20 > Bernard. >=20 Could you also check that the usage() function is updated in dpdk/app/test-= pmd/parameters.c Regards, Bernard. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5C2A1A067F for ; Thu, 28 Mar 2019 11:49:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 31C331B13F; Thu, 28 Mar 2019 11:49:29 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0D3DD1B13C for ; Thu, 28 Mar 2019 11:49:26 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 03:49:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,280,1549958400"; d="scan'208";a="311113565" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga005.jf.intel.com with ESMTP; 28 Mar 2019 03:49:25 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.7]) by IRSMSX107.ger.corp.intel.com ([169.254.10.15]) with mapi id 14.03.0415.000; Thu, 28 Mar 2019 10:49:24 +0000 From: "Iremonger, Bernard" To: "Iremonger, Bernard" , "Yang, Qiming" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Yang, Qiming" Thread-Topic: [dpdk-dev] [PATCH v4 4/5] app/testpmd: add VXLAN-GPE to tunnel type Thread-Index: AQHU3jQ67b6jnjjHX0+jebwtnZhlVKYfVElAgAGWWyA= Date: Thu, 28 Mar 2019 10:49:23 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D77675@IRSMSX108.ger.corp.intel.com> References: <20190318154200.28409-1-qiming.yang@intel.com> <20190319163658.115513-1-qiming.yang@intel.com> <20190319163658.115513-5-qiming.yang@intel.com> <8CEF83825BEC744B83065625E567D7C260D76F15@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D76F15@IRSMSX108.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDA1YjRlYTctOTg5OS00N2VlLWFhYWUtYmM1OWUyOGMzY2Y2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYVczTm1qWCtQRXIzbTgrZlEzWDVSZnl6Nlh2bDZRc1djRnVTMUVWeHZHbENmTDZsb1wvdUc2THZkbWZLRUE2NjYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 4/5] app/testpmd: add VXLAN-GPE to tunnel type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190328104923.xmB1d-SBfSkaNHMTkvdshoaIVZjjctCNzmNq9F6m4Bs@z> Hi Qiming, > > Subject: [dpdk-dev] [PATCH v4 4/5] app/testpmd: add VXLAN-GPE to > > tunnel type > > > > This patch added new item "vxlan-gpe" to tunnel_type to support new > > VXLAN-GPE packet type, and its clasification. > > > > Signed-off-by: Qiming Yang > > --- > > app/test-pmd/cmdline.c | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > db53cc0..08a554c 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -8710,6 +8710,8 @@ cmd_tunnel_filter_parsed(void *parsed_result, > > > > if (!strcmp(res->tunnel_type, "vxlan")) > > tunnel_filter_conf.tunnel_type =3D > > RTE_TUNNEL_TYPE_VXLAN; > > + else if (!strcmp(res->tunnel_type, "vxlan-gpe")) > > + tunnel_filter_conf.tunnel_type =3D > > RTE_TUNNEL_TYPE_VXLAN_GPE; > > else if (!strcmp(res->tunnel_type, "nvgre")) > > tunnel_filter_conf.tunnel_type =3D > > RTE_TUNNEL_TYPE_NVGRE; > > else if (!strcmp(res->tunnel_type, "ipingre")) @@ -8759,7 +8761,7 > @@ > > cmdline_parse_token_ipaddr_t cmd_tunnel_filter_ip_value =3D > > ip_value); > > cmdline_parse_token_string_t cmd_tunnel_filter_tunnel_type =3D > > TOKEN_STRING_INITIALIZER(struct cmd_tunnel_filter_result, > > - tunnel_type, "vxlan#nvgre#ipingre"); > > + tunnel_type, "vxlan#nvgre#ipingre#vxlan-gpe"); > > > > cmdline_parse_token_string_t cmd_tunnel_filter_filter_type =3D > > TOKEN_STRING_INITIALIZER(struct cmd_tunnel_filter_result, @@ - > > 8883,6 +8885,8 @@ cmd_cfg_tunnel_udp_port_parsed(void > *parsed_result, > > tunnel_udp.prot_type =3D RTE_TUNNEL_TYPE_VXLAN; > > } else if (!strcmp(res->tunnel_type, "geneve")) { > > tunnel_udp.prot_type =3D RTE_TUNNEL_TYPE_GENEVE; > > + } else if (!strcmp(res->tunnel_type, "vxlan-gpe")) { > > + tunnel_udp.prot_type =3D RTE_TUNNEL_TYPE_VXLAN_GPE; > > } else { > > printf("Invalid tunnel type\n"); > > return; > > @@ -8917,7 +8921,7 @@ cmdline_parse_token_string_t > > cmd_config_tunnel_udp_port_action =3D > > "add#rm"); > > cmdline_parse_token_string_t > cmd_config_tunnel_udp_port_tunnel_type > > =3D > > TOKEN_STRING_INITIALIZER(struct cmd_config_tunnel_udp_port, > > tunnel_type, > > - "vxlan#geneve"); > > + "vxlan#geneve#vxlan-gpe"); > > cmdline_parse_token_num_t cmd_config_tunnel_udp_port_value =3D > > TOKEN_NUM_INITIALIZER(struct cmd_config_tunnel_udp_port, > udp_port, > > UINT16); > > @@ -8925,7 +8929,7 @@ cmdline_parse_token_num_t > > cmd_config_tunnel_udp_port_value =3D cmdline_parse_inst_t > > cmd_cfg_tunnel_udp_port =3D { > > .f =3D cmd_cfg_tunnel_udp_port_parsed, > > .data =3D NULL, > > - .help_str =3D "port config udp_tunnel_port add|rm > > vxlan|geneve ", > > + .help_str =3D "port config udp_tunnel_port add|rm > > +vxlan|geneve|vxlan-gpe ", > > .tokens =3D { > > (void *)&cmd_config_tunnel_udp_port_port, > > (void *)&cmd_config_tunnel_udp_port_config, > > -- > > 2.9.5 >=20 > Should the help strings at lines 374, 378 , 861 in cmdline.c be updated f= or > vxlan-gpe? > Should the help string at lines 2188, 8779 in cmdline.c be updated for v= xlan- > gpe? >=20 > The function flowtype_to_str() at line 11922 should be updated for for > vxlan-gpe. >=20 > There should also be an update in doc/guides/tesptpmd_app_ug/*.rst for > vxlan-gpe. >=20 > Regards, >=20 > Bernard. >=20 Could you also check that the usage() function is updated in dpdk/app/test-= pmd/parameters.c Regards, Bernard.