Correct typing mistakes in several places. 1) "Those command will" ==> "These commands will" 2) icmp6_nd_opt_sla_eth ==> icmp6_nd_opt_tla_eth (change 's' to 't' for 'target' where applicable) Fixes: 1960be7d32f8 ("app/testpmd: add VXLAN encap/decap") Cc: stable@dpdk.org Signed-off-by: Dekel Peled <dekelp@mellanox.com> --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index c6f8b2c..9de3bf7 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -1587,7 +1587,7 @@ Configure the outer layer to encapsulate a packet inside a VXLAN tunnel:: udp-dst (udp-dst) ip-tos (ip-tos) ip-ttl (ip-ttl) ip-src (ip-src) \ ip-dst (ip-dst) eth-src (eth-src) eth-dst (eth-dst) -Those command will set an internal configuration inside testpmd, any following +These commands will set an internal configuration inside testpmd, any following flow rule using the action vxlan_encap will use the last configuration set. To have a different encapsulation header, one of those commands must be called before the flow rule creation. @@ -1602,7 +1602,7 @@ Configure the outer layer to encapsulate a packet inside a NVGRE tunnel:: set nvgre-with-vlan ip-version (ipv4|ipv6) tni (tni) ip-src (ip-src) \ ip-dst (ip-dst) vlan-tci (vlan-tci) eth-src (eth-src) eth-dst (eth-dst) -Those command will set an internal configuration inside testpmd, any following +These commands will set an internal configuration inside testpmd, any following flow rule using the action nvgre_encap will use the last configuration set. To have a different encapsulation header, one of those commands must be called before the flow rule creation. @@ -1645,7 +1645,7 @@ Configure the outer layer to encapsulate a packet inside a MPLSoGRE tunnel:: ip-src (ip-src) ip-dst (ip-dst) vlan-tci (vlan-tci) \ eth-src (eth-src) eth-dst (eth-dst) -Those command will set an internal configuration inside testpmd, any following +These commands will set an internal configuration inside testpmd, any following flow rule using the action mplsogre_encap will use the last configuration set. To have a different encapsulation header, one of those commands must be called before the flow rule creation. @@ -1658,7 +1658,7 @@ Configure the outer layer to decapsulate MPLSoGRE packet:: set mplsogre_decap ip-version (ipv4|ipv6) set mplsogre_decap-with-vlan ip-version (ipv4|ipv6) -Those command will set an internal configuration inside testpmd, any following +These commands will set an internal configuration inside testpmd, any following flow rule using the action mplsogre_decap will use the last configuration set. To have a different decapsulation header, one of those commands must be called before the flow rule creation. @@ -1675,7 +1675,7 @@ Configure the outer layer to encapsulate a packet inside a MPLSoUDP tunnel:: udp-src (udp-src) udp-dst (udp-dst) ip-src (ip-src) ip-dst (ip-dst) \ vlan-tci (vlan-tci) eth-src (eth-src) eth-dst (eth-dst) -Those command will set an internal configuration inside testpmd, any following +These commands will set an internal configuration inside testpmd, any following flow rule using the action mplsoudp_encap will use the last configuration set. To have a different encapsulation header, one of those commands must be called before the flow rule creation. @@ -1688,7 +1688,7 @@ Configure the outer layer to decapsulate MPLSoUDP packet:: set mplsoudp_decap ip-version (ipv4|ipv6) set mplsoudp_decap-with-vlan ip-version (ipv4|ipv6) -Those command will set an internal configuration inside testpmd, any following +These commands will set an internal configuration inside testpmd, any following flow rule using the action mplsoudp_decap will use the last configuration set. To have a different decapsulation header, one of those commands must be called before the flow rule creation. @@ -3709,7 +3709,7 @@ This section lists supported pattern items and their attributes, if any. - ``sla {MAC-48}``: source Ethernet LLA. -- ``icmp6_nd_opt_sla_eth``: match ICMPv6 neighbor discovery target Ethernet +- ``icmp6_nd_opt_tla_eth``: match ICMPv6 neighbor discovery target Ethernet link-layer address option. - ``tla {MAC-48}``: target Ethernet LLA. -- 1.8.3.1
Correct typing mistakes in several places. 1) "Those command will" ==> "These commands will" 2) icmp6_nd_opt_sla_eth ==> icmp6_nd_opt_tla_eth (change 's' to 't' for 'target' where applicable) Fixes: 1960be7d32f8 ("app/testpmd: add VXLAN encap/decap") Cc: stable@dpdk.org Signed-off-by: Dekel Peled <dekelp@mellanox.com> --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index c6f8b2c..9de3bf7 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -1587,7 +1587,7 @@ Configure the outer layer to encapsulate a packet inside a VXLAN tunnel:: udp-dst (udp-dst) ip-tos (ip-tos) ip-ttl (ip-ttl) ip-src (ip-src) \ ip-dst (ip-dst) eth-src (eth-src) eth-dst (eth-dst) -Those command will set an internal configuration inside testpmd, any following +These commands will set an internal configuration inside testpmd, any following flow rule using the action vxlan_encap will use the last configuration set. To have a different encapsulation header, one of those commands must be called before the flow rule creation. @@ -1602,7 +1602,7 @@ Configure the outer layer to encapsulate a packet inside a NVGRE tunnel:: set nvgre-with-vlan ip-version (ipv4|ipv6) tni (tni) ip-src (ip-src) \ ip-dst (ip-dst) vlan-tci (vlan-tci) eth-src (eth-src) eth-dst (eth-dst) -Those command will set an internal configuration inside testpmd, any following +These commands will set an internal configuration inside testpmd, any following flow rule using the action nvgre_encap will use the last configuration set. To have a different encapsulation header, one of those commands must be called before the flow rule creation. @@ -1645,7 +1645,7 @@ Configure the outer layer to encapsulate a packet inside a MPLSoGRE tunnel:: ip-src (ip-src) ip-dst (ip-dst) vlan-tci (vlan-tci) \ eth-src (eth-src) eth-dst (eth-dst) -Those command will set an internal configuration inside testpmd, any following +These commands will set an internal configuration inside testpmd, any following flow rule using the action mplsogre_encap will use the last configuration set. To have a different encapsulation header, one of those commands must be called before the flow rule creation. @@ -1658,7 +1658,7 @@ Configure the outer layer to decapsulate MPLSoGRE packet:: set mplsogre_decap ip-version (ipv4|ipv6) set mplsogre_decap-with-vlan ip-version (ipv4|ipv6) -Those command will set an internal configuration inside testpmd, any following +These commands will set an internal configuration inside testpmd, any following flow rule using the action mplsogre_decap will use the last configuration set. To have a different decapsulation header, one of those commands must be called before the flow rule creation. @@ -1675,7 +1675,7 @@ Configure the outer layer to encapsulate a packet inside a MPLSoUDP tunnel:: udp-src (udp-src) udp-dst (udp-dst) ip-src (ip-src) ip-dst (ip-dst) \ vlan-tci (vlan-tci) eth-src (eth-src) eth-dst (eth-dst) -Those command will set an internal configuration inside testpmd, any following +These commands will set an internal configuration inside testpmd, any following flow rule using the action mplsoudp_encap will use the last configuration set. To have a different encapsulation header, one of those commands must be called before the flow rule creation. @@ -1688,7 +1688,7 @@ Configure the outer layer to decapsulate MPLSoUDP packet:: set mplsoudp_decap ip-version (ipv4|ipv6) set mplsoudp_decap-with-vlan ip-version (ipv4|ipv6) -Those command will set an internal configuration inside testpmd, any following +These commands will set an internal configuration inside testpmd, any following flow rule using the action mplsoudp_decap will use the last configuration set. To have a different decapsulation header, one of those commands must be called before the flow rule creation. @@ -3709,7 +3709,7 @@ This section lists supported pattern items and their attributes, if any. - ``sla {MAC-48}``: source Ethernet LLA. -- ``icmp6_nd_opt_sla_eth``: match ICMPv6 neighbor discovery target Ethernet +- ``icmp6_nd_opt_tla_eth``: match ICMPv6 neighbor discovery target Ethernet link-layer address option. - ``tla {MAC-48}``: target Ethernet LLA. -- 1.8.3.1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dekel Peled
> Sent: Sunday, March 31, 2019 11:21 AM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; orika@mellanox.com; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: fix typos in testpmd user guide
>
> Correct typing mistakes in several places.
> 1) "Those command will" ==> "These commands will"
> 2) icmp6_nd_opt_sla_eth ==> icmp6_nd_opt_tla_eth
> (change 's' to 't' for 'target' where applicable)
>
> Fixes: 1960be7d32f8 ("app/testpmd: add VXLAN encap/decap")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dekel Peled
> Sent: Sunday, March 31, 2019 11:21 AM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; orika@mellanox.com; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: fix typos in testpmd user guide
>
> Correct typing mistakes in several places.
> 1) "Those command will" ==> "These commands will"
> 2) icmp6_nd_opt_sla_eth ==> icmp6_nd_opt_tla_eth
> (change 's' to 't' for 'target' where applicable)
>
> Fixes: 1960be7d32f8 ("app/testpmd: add VXLAN encap/decap")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
On 4/1/2019 5:19 PM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dekel Peled
>> Sent: Sunday, March 31, 2019 11:21 AM
>> To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo
>> <wenzhuo.lu@intel.com>
>> Cc: dev@dpdk.org; orika@mellanox.com; stable@dpdk.org
>> Subject: [dpdk-dev] [PATCH] doc: fix typos in testpmd user guide
>>
>> Correct typing mistakes in several places.
>> 1) "Those command will" ==> "These commands will"
>> 2) icmp6_nd_opt_sla_eth ==> icmp6_nd_opt_tla_eth
>> (change 's' to 't' for 'target' where applicable)
>>
>> Fixes: 1960be7d32f8 ("app/testpmd: add VXLAN encap/decap")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
>
Applied to dpdk-next-net/master, thanks.
On 4/1/2019 5:19 PM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dekel Peled
>> Sent: Sunday, March 31, 2019 11:21 AM
>> To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo
>> <wenzhuo.lu@intel.com>
>> Cc: dev@dpdk.org; orika@mellanox.com; stable@dpdk.org
>> Subject: [dpdk-dev] [PATCH] doc: fix typos in testpmd user guide
>>
>> Correct typing mistakes in several places.
>> 1) "Those command will" ==> "These commands will"
>> 2) icmp6_nd_opt_sla_eth ==> icmp6_nd_opt_tla_eth
>> (change 's' to 't' for 'target' where applicable)
>>
>> Fixes: 1960be7d32f8 ("app/testpmd: add VXLAN encap/decap")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
>
Applied to dpdk-next-net/master, thanks.