From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Peng, Yuan" <yuan.peng@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec
Date: Fri, 7 Jun 2019 13:59:15 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260DAD471@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <A2573D2ACFCADC41BB3BE09C6DE313CA07EE5CFD@PGSMSX103.gar.corp.intel.com>
Hi Wei,
<snip>
> > Subject: [PATCH v2] app/testpmd: remove port stop check for macsec
> >
> > There is no need to do such a check when set macsec for ixgbe,
> > reconfig_device_queueand is also useless. If we do not delete this
Typo: space missing before "and" in previous line.
> > unnessary code, users have to sotp port before enable or disable
Typo: "sotp" should be "stop"
> > macsec, then restart this port after make configuration. All these
Typo: "these" should be "this"
> > process is useless. As this cmdline is a private API which is only used by ixgbe
> NIC, so remove it.
> >
> > Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Otherwise
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
next prev parent reply other threads:[~2019-06-07 13:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 7:20 [dpdk-dev] [PATCH] " Wei Zhao
2019-05-09 7:20 ` Wei Zhao
2019-05-10 8:41 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2019-05-10 8:41 ` Wei Zhao
2019-05-13 3:30 ` Zhao1, Wei
2019-05-13 3:30 ` Zhao1, Wei
2019-06-07 13:59 ` Iremonger, Bernard [this message]
2019-06-10 6:40 ` Zhao1, Wei
2019-06-10 6:07 ` [dpdk-dev] [PATCH v3] " Wei Zhao
2019-06-27 17:23 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-06-30 21:50 ` Thomas Monjalon
2019-07-01 16:39 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C260DAD471@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=yuan.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).