From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 936E8A0487 for ; Wed, 3 Jul 2019 17:23:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 37A8A2956; Wed, 3 Jul 2019 17:23:35 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 2292323D; Wed, 3 Jul 2019 17:23:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2019 08:23:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,446,1557212400"; d="scan'208";a="363072985" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga006.fm.intel.com with ESMTP; 03 Jul 2019 08:23:32 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.46]) by IRSMSX103.ger.corp.intel.com ([169.254.3.140]) with mapi id 14.03.0439.000; Wed, 3 Jul 2019 16:23:31 +0100 From: "Iremonger, Bernard" To: "Wang, Haiyue" , "Ye, Xiaolong" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: fix setting RSS queue rule failure on fedora30 Thread-Index: AQHVMJ42PyIC0vNRO0mPhhULL5zIdaa2yqkAgAI5zZA= Date: Wed, 3 Jul 2019 15:23:30 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260DC1484@IRSMSX108.ger.corp.intel.com> References: <1561459083-29808-1-git-send-email-haiyue.wang@intel.com> <20190702130043.GA86373@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWM2YzNmNjYtNzYxYi00ZjcyLWJkNjAtYzZhMDVmOWEwZmZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicGtJSkdNbDJweGk4ZGxkcUVFbDFlZ095dlJHUmd0NjEwMG9PTUE5N2ZoSUhkNXdZa2d5dFRGZmJzekpZbFB0dSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix setting RSS queue rule failure on fedora30 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix setting RSS queue > > rule failure on fedora30 > > > > On 06/25, Haiyue Wang wrote: > > >Declare a local variable 'arg' to hold the pointer to ARGS_ENTRY_ARB, > > >otherwise, the pop 'arg' in 'parse_int' holds wrong data like 'arg-> > > >offset =3D 5912737, arg->size =3D 0', this caused the parse failure. > > > > > >If calling like 'push_args(ctx, ARGS_ENTRY_ARB..)', the below code > > >for assgining 'offset & size' will be missed for some gcc optimization= . > > > > > >parse_vc_action_rss_queue > > > 29c5: c5 f9 ef c0 vpxor %xmm0,%xmm0,%xmm0 > > > 29c9: 43 8d 44 24 68 lea 0x68(%r12,%r12,1),%eax > > > 29ce: 48 c7 44 24 20 00 00 movq $0x0,0x20(%rsp) > > > 29d5: 00 00 > > > 29d7: c5 f8 29 44 24 10 vmovaps %xmm0,0x10(%rsp) > > > 29dd: 89 44 24 18 mov %eax,0x18(%rsp) > > > 29e1: 48 63 83 0c 01 00 00 movslq 0x10c(%rbx),%rax > > > 29e8: c7 44 24 1c 02 00 00 movl $0x2,0x1c(%rsp) > > > 29ef: 00 > > > 29f0: c5 f8 29 04 24 vmovaps %xmm0,(%rsp) > > > > > >The above assembly code is from this modification with: > > > gcc version 9.1.1 20190503 (Red Hat 9.1.1-1) (GCC) > > > Fedora release 30 (Thirty) > > > 5.1.11-300.fc30.x86_64 > > > > Do you mean without your patch, the above assembly code (for assgining > > offset & size) is missing, after apply this patch, it would show up? > > > Yes. > > > > > >Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action > > >configuration") > > >Cc: stable@dpdk.org > > > > > >Signed-off-by: Haiyue Wang Reviewed-by: Xiaolong Ye Acked-by: Bernard Iremonge