From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 217B8A0487 for ; Thu, 4 Jul 2019 10:53:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E55601B955; Thu, 4 Jul 2019 10:53:12 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 73BA11B953; Thu, 4 Jul 2019 10:53:10 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jul 2019 01:53:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,450,1557212400"; d="scan'208";a="184956391" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 04 Jul 2019 01:53:07 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.229]) by IRSMSX102.ger.corp.intel.com ([169.254.2.59]) with mapi id 14.03.0439.000; Thu, 4 Jul 2019 09:53:07 +0100 From: "Iremonger, Bernard" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] app/testpmd: fix to add offloads confguration for queue Thread-Index: AQHVMi6VPN6EEUOVZke0x7cXdfZ+kqa6Jx4g Date: Thu, 4 Jul 2019 08:53:06 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260DC5A36@IRSMSX108.ger.corp.intel.com> References: <1562131464-58732-1-git-send-email-wei.zhao1@intel.com> <1562218537-33583-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1562218537-33583-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGY5NmJlOGItM2RiOC00YTA3LTk5NjctMDYzOTRlMjQ3ZGQ3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZGxnaDRWS1g4MkxxRW15cnJRQjRMWG5ya3ZQTXdERDMxZWt5a2J3XC9vQThHKzRUeUdIKzM1S1pRN3NEckRseHgifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix to add offloads confguration for queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhao1, Wei > Sent: Thursday, July 4, 2019 6:36 AM > To: dev@dpdk.org > Cc: stable@dpdk.org; Iremonger, Bernard ; > Zhao1, Wei > Subject: [PATCH v2] app/testpmd: fix to add offloads confguration for que= ue >=20 > When adding offloads from commandline, not only port related configuratio= n > bits should be set, but also queue related offloads configuration bits, o= r it will > cause error. > For example, test in this process for ixgbe: > (1)./x86_64-native-linuxapp-gcc/app/testpmd -c 0x6 -n 4 > -- -i --portmask=3D0x1 --port-topology=3Dloop --disable-crc-strip (2)port= stop all > (3)port config all crc-strip on (4)port start all we will see "Fail to co= nfigure port > 0 rx queues" of warning info. >=20 > Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API") > Cc: stable@dpdk.org >=20 > Signed-off-by: wei zhao Acked-by: Bernard Iremonger