DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive rte_errno
@ 2019-07-05 12:18 Andrew Rybchenko
  2019-07-05 13:46 ` Iremonger, Bernard
  2019-07-08 12:06 ` Akhil Goyal
  0 siblings, 2 replies; 4+ messages in thread
From: Andrew Rybchenko @ 2019-07-05 12:18 UTC (permalink / raw)
  To: Radu Nicolau, Akhil Goyal; +Cc: dev, Dilshod Urazov, stable

From: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>

Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
Cc: stable@dpdk.org

Signed-off-by: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 examples/ipsec-secgw/sa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
index 8d47d1def..8044066a8 100644
--- a/examples/ipsec-secgw/sa.c
+++ b/examples/ipsec-secgw/sa.c
@@ -739,7 +739,7 @@ sa_create(const char *name, int32_t socket_id)
 			RTE_MEMZONE_1GB | RTE_MEMZONE_SIZE_HINT_ONLY);
 	if (mz == NULL) {
 		printf("Failed to allocate SA DB memory\n");
-		rte_errno = -ENOMEM;
+		rte_errno = ENOMEM;
 		return NULL;
 	}
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive rte_errno
  2019-07-05 12:18 [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive rte_errno Andrew Rybchenko
@ 2019-07-05 13:46 ` Iremonger, Bernard
  2019-07-06  8:41   ` Andrew Rybchenko
  2019-07-08 12:06 ` Akhil Goyal
  1 sibling, 1 reply; 4+ messages in thread
From: Iremonger, Bernard @ 2019-07-05 13:46 UTC (permalink / raw)
  To: Andrew Rybchenko, Nicolau, Radu, Akhil Goyal; +Cc: dev, Dilshod Urazov, stable

Hi Andrew, Dilshod

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andrew Rybchenko
> Sent: Friday, July 5, 2019 1:18 PM
> To: Nicolau, Radu <radu.nicolau@intel.com>; Akhil Goyal
> <akhil.goyal@nxp.com>
> Cc: dev@dpdk.org; Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive
> rte_errno
> 
> From: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
> 
> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
>  examples/ipsec-secgw/sa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c index
> 8d47d1def..8044066a8 100644
> --- a/examples/ipsec-secgw/sa.c
> +++ b/examples/ipsec-secgw/sa.c
> @@ -739,7 +739,7 @@ sa_create(const char *name, int32_t socket_id)
>  			RTE_MEMZONE_1GB |
> RTE_MEMZONE_SIZE_HINT_ONLY);
>  	if (mz == NULL) {
>  		printf("Failed to allocate SA DB memory\n");
> -		rte_errno = -ENOMEM;
> +		rte_errno = ENOMEM;
>  		return NULL;
>  	}
> 
> --
> 2.17.1

./devtools/check-git-log.sh -1
Wrong headline format:
        examples/ipsec-secgw: fix to set positive rte_errno

Otherwise
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive rte_errno
  2019-07-05 13:46 ` Iremonger, Bernard
@ 2019-07-06  8:41   ` Andrew Rybchenko
  0 siblings, 0 replies; 4+ messages in thread
From: Andrew Rybchenko @ 2019-07-06  8:41 UTC (permalink / raw)
  To: Iremonger, Bernard, Nicolau, Radu, Akhil Goyal
  Cc: dev, Dilshod Urazov, stable

On 05.07.2019 16:46, Iremonger, Bernard wrote:
> Hi Andrew, Dilshod
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andrew Rybchenko
>> Sent: Friday, July 5, 2019 1:18 PM
>> To: Nicolau, Radu <radu.nicolau@intel.com>; Akhil Goyal
>> <akhil.goyal@nxp.com>
>> Cc: dev@dpdk.org; Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>;
>> stable@dpdk.org
>> Subject: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive
>> rte_errno
>>
>> From: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
>>
>> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>>   examples/ipsec-secgw/sa.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c index
>> 8d47d1def..8044066a8 100644
>> --- a/examples/ipsec-secgw/sa.c
>> +++ b/examples/ipsec-secgw/sa.c
>> @@ -739,7 +739,7 @@ sa_create(const char *name, int32_t socket_id)
>>   			RTE_MEMZONE_1GB |
>> RTE_MEMZONE_SIZE_HINT_ONLY);
>>   	if (mz == NULL) {
>>   		printf("Failed to allocate SA DB memory\n");
>> -		rte_errno = -ENOMEM;
>> +		rte_errno = ENOMEM;
>>   		return NULL;
>>   	}
>>
>> --
>> 2.17.1
> ./devtools/check-git-log.sh -1
> Wrong headline format:
>          examples/ipsec-secgw: fix to set positive rte_errno
>
> Otherwise
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

It does not like underscore in headline. I think in this case it is 
better to
keep it as is instead of trying to describe rte_errno is a different way.

Thanks.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive rte_errno
  2019-07-05 12:18 [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive rte_errno Andrew Rybchenko
  2019-07-05 13:46 ` Iremonger, Bernard
@ 2019-07-08 12:06 ` Akhil Goyal
  1 sibling, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2019-07-08 12:06 UTC (permalink / raw)
  To: Andrew Rybchenko, Radu Nicolau; +Cc: dev, Dilshod Urazov, stable

Applied to dpdk-next-crypto

Thanks.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-07-08 12:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-05 12:18 [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive rte_errno Andrew Rybchenko
2019-07-05 13:46 ` Iremonger, Bernard
2019-07-06  8:41   ` Andrew Rybchenko
2019-07-08 12:06 ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).