From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1DED49612 for ; Wed, 15 Jun 2016 09:05:36 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 15 Jun 2016 00:05:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,475,1459839600"; d="scan'208";a="997924825" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 15 Jun 2016 00:05:35 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 15 Jun 2016 00:05:35 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.107]) with mapi id 14.03.0248.002; Wed, 15 Jun 2016 15:05:33 +0800 From: "Wang, Zhihong" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Ananyev, Konstantin" , "Richardson, Bruce" , "thomas.monjalon@6wind.com" Thread-Topic: [PATCH v2 5/5] testpmd: show topology at forwarding start Thread-Index: AQHRu/EaPOgI39Ux+0qIDz/MRJzSv5/ooJSAgAGPvlA= Date: Wed, 15 Jun 2016 07:05:33 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE09411075CAD7@SHSMSX103.ccr.corp.intel.com> References: <1462488421-118990-1-git-send-email-zhihong.wang@intel.com> <1464751663-135211-1-git-send-email-zhihong.wang@intel.com> <1464751663-135211-6-git-send-email-zhihong.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjZlMDEzMDktYjMyOS00YzU2LTkwODAtNGU1YTI3ZjE3ZmZmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Iks3eEk2OVZDdDV0WmNIU1FwWFVqVVBaR0JLQzZySjhOXC93dG10OGExTXVVPSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 5/5] testpmd: show topology at forwarding start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2016 07:05:37 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Tuesday, June 14, 2016 11:13 PM > To: Wang, Zhihong ; dev@dpdk.org > Cc: Ananyev, Konstantin ; Richardson, Bruce > ; thomas.monjalon@6wind.com > Subject: RE: [PATCH v2 5/5] testpmd: show topology at forwarding start >=20 >=20 > Hi Zhihong, >=20 > > -----Original Message----- > > From: Wang, Zhihong > > Sent: Wednesday, June 01, 2016 4:28 AM > > To: dev@dpdk.org > > Cc: Ananyev, Konstantin; Richardson, Bruce; De Lara Guarch, Pablo; > > thomas.monjalon@6wind.com; Wang, Zhihong > > Subject: [PATCH v2 5/5] testpmd: show topology at forwarding start > > > > This patch show topology at forwarding start. > > > > "show config fwd" also does this, but showing it directly can reduce th= e > > possibility of misconfiguration. > > > > > > Signed-off-by: Zhihong Wang > [...] >=20 > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > > index 9b1d99c..b946034 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -1009,7 +1009,7 @@ start_packet_forwarding(int with_tx_first) > > if(!no_flush_rx) > > flush_fwd_rx_queues(); > > > > - fwd_config_setup(); > > + fwd_config_setup_display(); >=20 > Bernard has made a patch that separates the display and setup of the > configuration, > (http://dpdk.org/dev/patchwork/patch/13650/) > so fwd_config_display() does not call fwd_config_setup() anymore. >=20 > Could you modify this patch, so you call fwd_config_setup() and > fwd_config_display()? Thanks for the info! I've updated this patch with a v3. Could you please help review? >=20 > Sorry for the confusion, > Pablo >=20 > > rxtx_config_display(); > > > > for (i =3D 0; i < cur_fwd_config.nb_fwd_ports; i++) {