From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9119A2935 for ; Fri, 14 Oct 2016 09:34:31 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 14 Oct 2016 00:34:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,491,1473145200"; d="scan'208";a="772507177" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 14 Oct 2016 00:34:31 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 14 Oct 2016 00:34:30 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 14 Oct 2016 00:34:30 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.139]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Fri, 14 Oct 2016 15:34:26 +0800 From: "Wang, Zhihong" To: "Wang, Zhihong" , Maxime Coquelin , "yuanhan.liu@linux.intel.com" , "Xie, Huawei" , "dev@dpdk.org" CC: "vkaplans@redhat.com" , "mst@redhat.com" , "stephen@networkplumber.org" Thread-Topic: [dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path Thread-Index: AQHSGJsuPULF2YwoOkWK68sRWtMF+6CnouKwgAAGbAA= Date: Fri, 14 Oct 2016 07:34:26 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE09414E7CE70C@SHSMSX103.ccr.corp.intel.com> References: <1474619303-16709-1-git-send-email-maxime.coquelin@redhat.com> <1474965769-24782-1-git-send-email-maxime.coquelin@redhat.com> <8F6C2BD409508844A0EFC19955BE09414E7CE6D1@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <8F6C2BD409508844A0EFC19955BE09414E7CE6D1@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2016 07:34:32 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wang, Zhihong > Sent: Friday, October 14, 2016 3:25 PM > To: Maxime Coquelin ; > yuanhan.liu@linux.intel.com; Xie, Huawei ; > dev@dpdk.org > Cc: vkaplans@redhat.com; mst@redhat.com; > stephen@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v4] vhost: Add indirect descriptors suppor= t > to the TX path >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxime Coquelin > > Sent: Tuesday, September 27, 2016 4:43 PM > > To: yuanhan.liu@linux.intel.com; Xie, Huawei ; > > dev@dpdk.org > > Cc: vkaplans@redhat.com; mst@redhat.com; > > stephen@networkplumber.org; Maxime Coquelin > > > > Subject: [dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support = to > > the TX path > > > > Indirect descriptors are usually supported by virtio-net devices, > > allowing to dispatch a larger number of requests. > > > > When the virtio device sends a packet using indirect descriptors, > > only one slot is used in the ring, even for large packets. > > > > The main effect is to improve the 0% packet loss benchmark. > > A PVP benchmark using Moongen (64 bytes) on the TE, and testpmd > > (fwd io for host, macswap for VM) on DUT shows a +50% gain for > > zero loss. > > > > On the downside, micro-benchmark using testpmd txonly in VM and > > rxonly on host shows a loss between 1 and 4%.i But depending on > > the needs, feature can be disabled at VM boot time by passing > > indirect_desc=3Doff argument to vhost-user device in Qemu. > > > > Signed-off-by: Maxime Coquelin >=20 >=20 > Hi Maxime, >=20 > Seems this patch can't with Windows virtio guest in my test. > Have you done similar tests before? >=20 > The way I test: >=20 > 1. Make sure https://patchwork.codeaurora.org/patch/84339/ is applied >=20 > 2. Start testpmd with iofwd between 2 vhost ports >=20 > 3. Start 2 Windows guests connected to the 2 vhost ports The mrg_rxbuf feature is on. >=20 > 4. Disable firewall and assign IP to each guest using ipconfig >=20 > 5. Use ping to test connectivity >=20 > When I disable this patch by setting: >=20 > 0ULL << VIRTIO_RING_F_INDIRECT_DESC, >=20 > the connection is fine, but when I restore: >=20 > 1ULL << VIRTIO_RING_F_INDIRECT_DESC, >=20 > the connection is broken. >=20 >=20 > Thanks > Zhihong >=20