From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 5C2865A8C for ; Mon, 23 Nov 2015 02:32:04 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 22 Nov 2015 17:32:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,334,1444719600"; d="scan'208";a="844948239" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 22 Nov 2015 17:32:02 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 22 Nov 2015 17:32:02 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 22 Nov 2015 17:32:02 -0800 Received: from shsmsx152.ccr.corp.intel.com ([169.254.6.193]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.83]) with mapi id 14.03.0248.002; Mon, 23 Nov 2015 09:32:00 +0800 From: "Wang, Zhihong" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH RFC v2 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling Thread-Index: AQHRI3FkgKINpJVGyUa58VkjPF/pbJ6klTsAgARA0bA= Date: Mon, 23 Nov 2015 01:31:59 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE094183533E@SHSMSX152.ccr.corp.intel.com> References: <1447984428-137897-1-git-send-email-zhihong.wang@intel.com> <1447984428-137897-3-git-send-email-zhihong.wang@intel.com> <20151120083258.033e0498@xeon-e3> In-Reply-To: <20151120083258.033e0498@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH RFC v2 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2015 01:32:04 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Saturday, November 21, 2015 12:33 AM > To: Wang, Zhihong > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH RFC v2 2/2] lib/librte_eal: Remove unneces= sary > hugepage zero-filling >=20 > On Thu, 19 Nov 2015 20:53:48 -0500 > Zhihong Wang wrote: >=20 > > The kernel fills new allocated (huge) pages with zeros. > > DPDK just has to touch the pages to trigger the allocation. > > > > Signed-off-by: Zhihong Wang >=20 > The code is correct, and optimized. > Don't you need to update the commit message since you no longer have to t= ouch > the pages. Thanks for pointing this out!