From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 892767E23 for ; Fri, 18 Dec 2015 03:39:55 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 17 Dec 2015 18:39:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,444,1444719600"; d="scan'208";a="15292108" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 17 Dec 2015 18:39:54 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Dec 2015 18:39:54 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 17 Dec 2015 18:39:54 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.28]) by shsmsx102.ccr.corp.intel.com ([169.254.2.158]) with mapi id 14.03.0248.002; Fri, 18 Dec 2015 10:39:51 +0800 From: "Wang, Zhihong" To: Ilya Maximets , "dev@dpdk.org" Thread-Topic: [PATCH] Unlink existing unused sockets at start up Thread-Index: AQHROL18zdU9dZ6Oi0WwBXs/UdhzH57OieqAgAF6y7A= Date: Fri, 18 Dec 2015 02:39:51 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE0941856F7D@SHSMSX103.ccr.corp.intel.com> References: <1450326062-105574-1-git-send-email-zhihong.wang@intel.com> <5672A0E5.4040904@samsung.com> In-Reply-To: <5672A0E5.4040904@samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjgzMWJlMGUtNTRiYi00NzFjLWFhM2ItNGQwZGM5MzZmOGE0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTzBHN0xaY0JmaHNhMDJzeHFuUzhvUUYzUEJTRFZ4cTYwQXA2bG1ScHgraz0ifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "s.dyasly@samsung.com" Subject: Re: [dpdk-dev] [PATCH] Unlink existing unused sockets at start up X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Dec 2015 02:39:55 -0000 > On 17.12.2015 07:21, Zhihong Wang wrote: > > This patch unlinks existing unused sockets (which cause new bindings to= fail, e.g. > vHost PMD) to ensure smooth startup. > > In a lot of cases DPDK applications are terminated abnormally without p= roper > resource release. >=20 > Original OVS related problem discussed previously here > ( http://dpdk.org/ml/archives/dev/2015-December/030326.html ) fixed in OV= S > by >=20 > commit 9b5422a98f817b9f2a1f8224cab7e1a8d0bbba1f > Author: Ilya Maximets > Date: Wed Dec 16 15:32:21 2015 +0300 >=20 > ovs-lib: Try to call exit before killing. >=20 > While killing OVS may not free all allocated resources. >=20 > Example: > Socket for vhost-user port will stay in a system > after 'systemctl stop openvswitch' and opening > that port after restart will fail. >=20 >=20 > So, the crash of application is the last point of discussion. >=20 > > Therefore, DPDK libs should be able to deal with unclean boot environme= nt. >=20 > Why are you think that recovery after crash of application is a problem o= f > underneath library? Thanks for the information! Yes ideally the underneath lib shouldn't meddle with the recovery logic. But I do think we should at least put a warning in the lib function said th= e app should make the path available. This is another topic though :-) Like we did in memcpy: /** * Copy 16 bytes from one location to another, * locations should not overlap. */ >=20 > Best regards, Ilya Maximets. >=20