From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C7038376C for ; Mon, 21 Dec 2015 04:31:26 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 20 Dec 2015 19:31:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,457,1444719600"; d="scan'208";a="621395468" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 20 Dec 2015 19:31:25 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 20 Dec 2015 19:31:24 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 20 Dec 2015 19:31:24 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.28]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.105]) with mapi id 14.03.0248.002; Mon, 21 Dec 2015 11:31:23 +0800 From: "Wang, Zhihong" To: Ilya Maximets , "dev@dpdk.org" Thread-Topic: [PATCH] Unlink existing unused sockets at start up Thread-Index: AQHROL18zdU9dZ6Oi0WwBXs/UdhzH57OieqAgAF6y7D//7tfAIAFCmsg Date: Mon, 21 Dec 2015 03:31:22 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE0941857356@SHSMSX103.ccr.corp.intel.com> References: <1450326062-105574-1-git-send-email-zhihong.wang@intel.com> <5672A0E5.4040904@samsung.com> <8F6C2BD409508844A0EFC19955BE0941856F7D@SHSMSX103.ccr.corp.intel.com> <5673A514.10004@samsung.com> In-Reply-To: <5673A514.10004@samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTdmNTI3NjMtZjc1My00NGU0LThiMzgtZDkxMWY3MTZkOGU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYnpleTlTVGlwRHZjMTV4RkhhUnpQeE9HQmQ5UHJ1Y1wvXC9zMldNUzhqRTNJPSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "s.dyasly@samsung.com" Subject: Re: [dpdk-dev] [PATCH] Unlink existing unused sockets at start up X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2015 03:31:27 -0000 > -----Original Message----- > From: Ilya Maximets [mailto:i.maximets@samsung.com] > Sent: Friday, December 18, 2015 2:18 PM > To: Wang, Zhihong ; dev@dpdk.org > Cc: p.fedin@samsung.com; yuanhan.liu@linux.intel.com; s.dyasly@samsung.co= m; > Xie, Huawei > Subject: Re: [PATCH] Unlink existing unused sockets at start up >=20 > On 18.12.2015 05:39, Wang, Zhihong wrote: >=20 > > Yes ideally the underneath lib shouldn't meddle with the recovery logic= . > > But I do think we should at least put a warning in the lib function > > said the app should make the path available. This is another topic thou= gh :-) > Like we did in memcpy: > > /** > > * Copy 16 bytes from one location to another, > > * locations should not overlap. > > */ > > >=20 > Isn't it enough to have an error in the log? Function comments and function code are different things and are both neces= sary. Also why wait till error occurs when a comment can warn the developer? >=20 > lib/librte_vhost/vhost_user/vhost-net-user.c:130: > RTE_LOG(ERR, VHOST_CONFIG, "fail to bind fd:%d, remove file:%s and try > again.\n", >=20 > Best regards, Ilya Maximets.