From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zhihong.wang@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id AB3535A13
 for <dev@dpdk.org>; Mon, 28 Dec 2015 02:37:48 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga103.jf.intel.com with ESMTP; 27 Dec 2015 17:37:47 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,488,1444719600"; d="scan'208";a="879565315"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
 by orsmga002.jf.intel.com with ESMTP; 27 Dec 2015 17:37:47 -0800
Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by
 FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Sun, 27 Dec 2015 17:37:46 -0800
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Sun, 27 Dec 2015 17:37:46 -0800
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.57]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.220]) with mapi id 14.03.0248.002;
 Mon, 28 Dec 2015 09:37:45 +0800
From: "Wang, Zhihong" <zhihong.wang@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Thread-Topic: [PATCH v2 1/3] app/test-pmd: Handle SIGINT and SIGTERM in testpmd
Thread-Index: AQHRPvhTunMORoXpBU+4zMHTKbW+dZ7e2tKAgADHWLA=
Date: Mon, 28 Dec 2015 01:37:44 +0000
Message-ID: <8F6C2BD409508844A0EFC19955BE09418620C2@SHSMSX103.ccr.corp.intel.com>
References: <1451011032-83106-1-git-send-email-zhihong.wang@intel.com>
 <1451011032-83106-2-git-send-email-zhihong.wang@intel.com>
 <20151227134209.15dc44ba@xeon-e3>
In-Reply-To: <20151227134209.15dc44ba@xeon-e3>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_IC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzU0ZTIzMzktMTc3Zi00ZmQzLWEwZDEtM2YwNWI1YzIxN2U1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjQuMTAuMTkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVWRJZlc3QVNDR0dWVWVpaHV2akN2Z1pDWmduVkUrWEtOYndzTG1XMjBpYz0ifQ==
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] app/test-pmd: Handle SIGINT and
 SIGTERM in testpmd
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Dec 2015 01:37:49 -0000

> > -	cl =3D cmdline_stdin_new(main_ctx, "testpmd> ");
> > -	if (cl =3D=3D NULL) {
> > +	testpmd_cl =3D cmdline_stdin_new(main_ctx, "testpmd> ");
> > +	if (testpmd_cl =3D=3D NULL) {
> >  		return;
> >  	}
>=20
> Style nit: don't need {} around single statement.
>=20
> > +static void
> > +sigint_handler(__rte_unused int signum) {
> > +	if (signum =3D=3D SIGINT || signum =3D=3D SIGTERM) {
>=20
> signmum is used, so don't want __rte_unused
>=20

Thanks :) Will fix these in the next version.