From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com [209.85.192.182]) by dpdk.org (Postfix) with ESMTP id 0DE04DE0 for ; Tue, 14 Jan 2014 20:56:03 +0100 (CET) Received: by mail-pd0-f182.google.com with SMTP id v10so89962pde.13 for ; Tue, 14 Jan 2014 11:57:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=h7PhmW+PQhTXIw7wcMgt5P5n25z4sh/3YqlDHF8XaQc=; b=g4lzsB2mnqIo/oZ9YBDxAZWv0/1HmAVCUbqIJlqHLWF/RcqlcWymRIC4l09uvFnPjg WSETxk5jupEDWp9Qe56XvBqCJinV37p2zBw8dYy+487mB4SYF6Q05RYAlVeVoSlEYk8s m8DrurTukkrHWtya96RJU2kDKOOhGA09T3+1EjYrOKKh+4pfeP6uaR3CUkYPCikFQ97b UG3sEDUQqLrmdvpdyrozigpiV1J0Ds8JfjNbF9v2VRAzt3PowKJYRn1+3LA3N8cUbXRc vT0cWGudxIaUaf6vy4Bm8rdJ8qsNMKalPRP2nmVrPk8El1oFZ3NugX2ZL/BrS1kh13wJ XY+Q== X-Gm-Message-State: ALoCoQnGt4xyZw7EWBQlzAJBBHKfqAriY8qi/7GG/njUVai+mDK6pyaXb/Svf3rijKMJ7ykhJgy4 X-Received: by 10.66.145.199 with SMTP id sw7mr3764971pab.143.1389729437143; Tue, 14 Jan 2014 11:57:17 -0800 (PST) Received: from [192.168.128.242] (50-76-35-254-ip-static.hfc.comcastbusiness.net. [50.76.35.254]) by mx.google.com with ESMTPSA id gv10sm3083881pbd.0.2014.01.14.11.57.14 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 14 Jan 2014 11:57:15 -0800 (PST) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) From: Daniel Kan In-Reply-To: Date: Tue, 14 Jan 2014 11:57:13 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <8FCA4423-9762-47DD-868C-028FD8AAE2BB@nyansa.com> References: <201401131131.06203.thomas.monjalon@6wind.com> <1389640630-21003-1-git-send-email-dan@nyansa.com> To: Maxime Leroy X-Mailer: Apple Mail (2.1827) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix RSS by setting mq_mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jan 2014 19:56:04 -0000 Maxime, Thanks for your comment. If we want testpmd to have RSS always enabled = out of box (note that rxq=3D1), then your suggestion makes sense. I=92m = new to dpdk so I was trying to preserve the current behavior. Now = looking back, I guess that=92s why we have an explicit disable-rss = option. If I don=92t hear any resistance by tomorrow, I will submit a = new patch. Thanks. Dan PS. I don=92t see port_rss_hash_conf_show in config.c, at not in 1.5.1 = branch. Which branch is this in? On Jan 14, 2014, at 9:42 AM, Maxime Leroy = wrote: > Hello, >=20 > Thanks for your patch fixing the regression introduced by my commit > (igb/ixgbe: ETH_MQ_RX_NONE should disable RSS). >=20 > I have one comment about your fix. I don't think there are any reasons > to not enable RSS with only one RX queue in testpmd. >=20 > RSS is mainly used in testpmd to spread traffic on the different rx = queues. > But you can use RSS with one rx queue for debbugging purpose. > For example, you can use the rxonly forward engine of the testpmd to = display > the RSS hash. (see pkt_burst_receive in app/test-pmd/rxonly.c) >=20 > An other issue about not enabling RSS with 1 queue, when you use the = command > show_rss_key in the testpmd, this one will display that the RSS is = enabled. > (because rss_hf !=3D 0; see port_rss_hash_conf_show function in > app/test-pmd/config.c) >=20 > Do you agree with my analyze ? >=20 > Thanks. >=20 > --=20 > Maxime Leroy