DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Xueming Li <xuemingl@nvidia.com>, Matan Azrad <matan@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: dev@dpdk.org, Asaf Penso <asafp@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v4 2/2] vdpa/mlx5: hardware error handling
Date: Wed, 28 Oct 2020 15:19:00 +0100
Message-ID: <8a129aeb-60e5-ba59-5547-a8565ce91cc4@redhat.com> (raw)
In-Reply-To: <1603787325-13707-2-git-send-email-xuemingl@nvidia.com>



On 10/27/20 9:28 AM, Xueming Li wrote:
> When hardware error happens, vdpa didn't get such information and leave
> driver in silent: working state but no response.
> 
> This patch subscribes firmware virtq error event and try to recover max
> 3 times in 3 seconds, stop virtq if max retry number reached.
> 
> When error happens, PMD log in warning level. If failed to recover,
> outputs error log. Query virtq statistics to get error counters report.
> 
> Acked-by: Matan Azrad <matan@nvidia.com>
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> ---
>  doc/guides/rel_notes/release_20_11.rst |   6 +-
>  doc/guides/vdpadevs/mlx5.rst           |   8 ++
>  drivers/vdpa/mlx5/mlx5_vdpa.c          |   2 +
>  drivers/vdpa/mlx5/mlx5_vdpa.h          |  37 +++++++
>  drivers/vdpa/mlx5/mlx5_vdpa_event.c    | 144 +++++++++++++++++++++++++
>  drivers/vdpa/mlx5/mlx5_vdpa_virtq.c    |  61 ++++++++---
>  6 files changed, 242 insertions(+), 16 deletions(-)
> 


Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  reply	other threads:[~2020-10-28 14:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26  7:16 [dpdk-dev] [PATCH 1/2] common/mlx5: add virtq attributes error fields Xueming Li
2020-10-26  7:16 ` [dpdk-dev] [PATCH 2/2] vdpa/mlx5: hardware error handling Xueming Li
2020-10-26  9:12 ` [dpdk-dev] [PATCH v1 1/2] common/mlx5: add virtq attributes error fields Xueming Li
2020-10-26  9:12 ` [dpdk-dev] [PATCH v1 2/2] vdpa/mlx5: hardware error handling Xueming Li
2020-10-26 11:14 ` [dpdk-dev] [PATCH v2 1/2] common/mlx5: add virtq attributes error fields Xueming Li
2020-10-26 11:14 ` [dpdk-dev] [PATCH v2 2/2] vdpa/mlx5: hardware error handling Xueming Li
2020-10-26 15:04 ` [dpdk-dev] [PATCH v3 1/2] common/mlx5: add virtq attributes error fields Xueming Li
2020-10-26 15:04 ` [dpdk-dev] [PATCH v3 2/2] vdpa/mlx5: hardware error handling Xueming Li
2020-10-27  8:28 ` [dpdk-dev] [PATCH v4 1/2] common/mlx5: add virtq attributes error fields Xueming Li
2020-10-28 13:59   ` Maxime Coquelin
2020-10-29  8:29   ` Maxime Coquelin
2020-10-27  8:28 ` [dpdk-dev] [PATCH v4 2/2] vdpa/mlx5: hardware error handling Xueming Li
2020-10-28 14:19   ` Maxime Coquelin [this message]
2020-10-29  8:29   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a129aeb-60e5-ba59-5547-a8565ce91cc4@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=asafp@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git