From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B017AA04DD; Wed, 28 Oct 2020 15:19:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7973CCACD; Wed, 28 Oct 2020 15:19:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 43EFC2C01 for ; Wed, 28 Oct 2020 15:19:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603894751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HbtlH3ePh29U2nGsqdpPQsGMiud9hhsFE/tp+uXNOXU=; b=dHJPFHZFkMxBYH3vNoMdEEOJeHium5h15y136BXS2/CVGWFOjLOh0eSM4Q/yZ+eA+o0DeP FhqYsj7OaaEFY3wwJiFXHCKq7qy+OkRqjiF7p9bf8nUNtNdXpXN0dwXFqzaHavatkp0+vz AYEdmM5BRVBHdP9bbp5eYTR4MLAsP28= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-EkMdzEKjM4aPD0NjVabOtg-1; Wed, 28 Oct 2020 10:19:07 -0400 X-MC-Unique: EkMdzEKjM4aPD0NjVabOtg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 42CA8879527; Wed, 28 Oct 2020 14:19:06 +0000 (UTC) Received: from [10.36.110.27] (unknown [10.36.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D5D696266E; Wed, 28 Oct 2020 14:19:02 +0000 (UTC) To: Xueming Li , Matan Azrad , Viacheslav Ovsiienko Cc: dev@dpdk.org, Asaf Penso References: <1603787325-13707-1-git-send-email-xuemingl@nvidia.com> <1603787325-13707-2-git-send-email-xuemingl@nvidia.com> From: Maxime Coquelin Message-ID: <8a129aeb-60e5-ba59-5547-a8565ce91cc4@redhat.com> Date: Wed, 28 Oct 2020 15:19:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <1603787325-13707-2-git-send-email-xuemingl@nvidia.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 2/2] vdpa/mlx5: hardware error handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/27/20 9:28 AM, Xueming Li wrote: > When hardware error happens, vdpa didn't get such information and leave > driver in silent: working state but no response. > > This patch subscribes firmware virtq error event and try to recover max > 3 times in 3 seconds, stop virtq if max retry number reached. > > When error happens, PMD log in warning level. If failed to recover, > outputs error log. Query virtq statistics to get error counters report. > > Acked-by: Matan Azrad > Signed-off-by: Xueming Li > --- > doc/guides/rel_notes/release_20_11.rst | 6 +- > doc/guides/vdpadevs/mlx5.rst | 8 ++ > drivers/vdpa/mlx5/mlx5_vdpa.c | 2 + > drivers/vdpa/mlx5/mlx5_vdpa.h | 37 +++++++ > drivers/vdpa/mlx5/mlx5_vdpa_event.c | 144 +++++++++++++++++++++++++ > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 61 ++++++++--- > 6 files changed, 242 insertions(+), 16 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime