From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 1DD0FDE5 for ; Wed, 1 Feb 2017 09:13:45 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id r141so26336605wmg.1 for ; Wed, 01 Feb 2017 00:13:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=A518RAmiZtRRGdZHDomrJZIg65etEyOBYjhOpDWnPO4=; b=qXLQqyTodk5JrR35Rblfx1e/U9nAl7Bfcza8hTsVYyALT5Da69wpYrosAcrDafXmhY DHT2Y7cHLLt3/q9z32XdlxHUwQGSS38Bae8XmfHVDWqw3CFYFqa6KFi5e5amb/mPQW1e rXzB6GLkiXlb9Tzr4C42+5Cn3sXoMfHi1HL8I44CeCeSXLucqlGPQPhqPSIXkHholWHb SHbVpMWxr0KC/1h64aqLG3FbCBUPCFnjNFiVNE2SjUF4iWAKxOqCx0dka4xMzFc6t5Wq RWOmHzrRCn3DAfbCzk+4JhjMj5Cc/kacYTWCM6wY607cdIGuTKQJslHZHTsdRCt7T+Op B26Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=A518RAmiZtRRGdZHDomrJZIg65etEyOBYjhOpDWnPO4=; b=pdiSEPBtMWRD2g9w5rKDArnrpnilOHOeCP5MhgJ2TpMvQvyzc1G42qnPZ2+QNxnunU 6Y8SBS72OIyKVwtMDSi4yHNRT/w7W1t1PRRXQ+LydkFdPczfENKmJBe368WQ7IAjDZLD aMRbI79XzGOi0MHpi5k6qcjVVclcnGNHgkqhF9McBLZhR6qXCRnueWA2ij8ffYwYbyqJ QmORia/RtWvnahTPGSglsgSS69IuCo+SG30zFuvno5FXD7fI9iC1KRSmgLsWm0XaKWAB l16UndmcAKVN0RAb8YoZDfPUlef8uyR79Jn3wbkLZdwsKH1CL2ZFiM22V1fX4glYEnfN iRIQ== X-Gm-Message-State: AIkVDXLBONAWefLIDHgmhLxUDJL4TMm0yRwuppEpM7ZiplQTZ4QBUyp0wD93KGLLUJ6AawEs X-Received: by 10.28.150.194 with SMTP id y185mr1387367wmd.47.1485936824693; Wed, 01 Feb 2017 00:13:44 -0800 (PST) Received: from [10.16.0.184] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 202sm28198568wmp.20.2017.02.01.00.13.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Feb 2017 00:13:44 -0800 (PST) To: "Wiles, Keith" References: <1485855778-15496-1-git-send-email-pascal.mazon@6wind.com> <39a46c11-66c4-d8ed-a2bc-d9421cb4afd0@6wind.com> <9fa2c783-349c-e20c-0e57-0c24e67a4683@intel.com> <9C574760-33CF-4163-94D4-A0C919F4592C@intel.com> <74B7FC24-638D-4A48-A02D-C80B5B4E7E2B@intel.com> <78727e66-3588-79ab-6448-9858c19e2361@6wind.com> Cc: "Yigit, Ferruh" , "dev@dpdk.org" From: Pascal Mazon Message-ID: <8a13261b-215c-e294-1f61-b57e5ea998eb@6wind.com> Date: Wed, 1 Feb 2017 09:11:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/6] net/tap: use correct tap name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Feb 2017 08:13:45 -0000 On 02/01/2017 12:29 AM, Wiles, Keith wrote: > >> On Jan 31, 2017, at 10:39 AM, Pascal Mazon wrote: >> >> On 01/31/2017 05:06 PM, Wiles, Keith wrote:> >>> Looking at the changes to set the link up/down and the adding the two functions. I noticed in the stop/start routines I was set the link in DPDK and not adjusting the interface link. Should the stop/start routine also do the same thing? >>> >> >> Well, my patch is probably wrong. >> The best option would probably be to set dev->data->dev_link.link_status >> appropriately inside tap_link_set() only. >> >> I'm not sure it's compulsory to actually set the link UP in tap_dev_start() >> (respectively DOWN in tap_dev_stop()). >> If it is, however, it would be best done using tap_link_set() in those >> functions. > > I was setting the link up/down in both places in the old code. The gotta is link up/down came later (I guess) and applications only call start/stop. In the other drivers like ring the like they tend to set link in start/stop and in link up/down, which is what I patterned my driver on. > > I looked around and the only applications calling link up/down was testpmd and ip_pipeline, but all of the apps call start/stop. Even the docs to not suggest that link up/down be used it appears start/stop must set the Link state and the developer can call link up/down APIs if needed for others reasons. > > I assume the link up/down only effects the link state and the start/stop is creating/destroying resources. > > My only solution I guess is to add the link up/down code to the start/stop API. I'm not sure I understand your conclusion. If the apps usually call start/stop only, then definitely those functions should set the link state appropriately. To that effect, I think it best to just call tap_link_set() in tap_dev_start() (and similar for stopping). Apps with just start/stop functions would get the expected behavior, and the tap PMD would also support setting the link up/down independently, for testpmd and ip_pipeline for example. Does that sound fine? > >> >> -- >> Pascal Mazon >> www.6wind.com > > Regards, > Keith > -- Pascal Mazon www.6wind.com