From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D768A42AE1;
	Wed, 17 May 2023 13:46:26 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B1119406B7;
	Wed, 17 May 2023 13:46:26 +0200 (CEST)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id A939E4067B;
 Wed, 17 May 2023 13:46:25 +0200 (CEST)
Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.54])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QLrqV5LQjzsRQS;
 Wed, 17 May 2023 19:44:22 +0800 (CST)
Received: from [10.67.103.231] (10.67.103.231) by
 kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.23; Wed, 17 May 2023 19:46:22 +0800
Message-ID: <8a170690-7371-7a8f-c0cb-53ec9918254f@huawei.com>
Date: Wed, 17 May 2023 19:46:21 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH V8] ethdev: fix one address occupies two entries in MAC
 addrs
To: Ferruh Yigit <ferruh.yigit@amd.com>
CC: <thomas@monjalon.net>, <andrew.rybchenko@oktetlabs.ru>,
 <liudongdong3@huawei.com>, <huangdaode@huawei.com>,
 <fengchengwen@huawei.com>, <dev@dpdk.org>, "techboard@dpdk.org"
 <techboard@dpdk.org>
References: <20221020093102.20679-1-lihuisong@huawei.com>
 <20230202123625.14975-1-lihuisong@huawei.com>
 <9fe8b055-2530-0cc3-c5fd-6672b2f569c0@huawei.com>
 <abde5375-cd50-f9a9-a062-9504577b4236@amd.com>
 <6d809c54-ce59-2564-3cfb-7ffe681c8a7f@huawei.com>
 <8bdbde41-18d0-0b01-e706-d13eed98425f@amd.com>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <8bdbde41-18d0-0b01-e706-d13eed98425f@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.231]
X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To
 kwepemm600004.china.huawei.com (7.193.23.242)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org


在 2023/5/17 16:53, Ferruh Yigit 写道:
> On 5/17/2023 8:45 AM, lihuisong (C) wrote:
>> 在 2023/5/16 22:13, Ferruh Yigit 写道:
>>> On 5/16/2023 12:47 PM, lihuisong (C) wrote:
>>>> Hi Ferruh,
>>>>
>>>> There is no result on techboard.
>>>> How to deal with this problem next?
>>> +techboard for comment.
>>>
>>>
>>> Btw, what was your positioning to Bruce's suggestion,
>>> when a MAC address is in the list, fail to set it as default and enforce
>>> user do the corrective action (delete MAC explicitly etc...).
>> If a MAC address is in the list, rte_eth_dev_default_mac_addr_set
>> returns failure?
> Yes.
> In that case API can return EEXIST or similar. In this case user need to
> call 'rte_eth_dev_mac_addr_remove()' first and call
> 'rte_eth_dev_default_mac_addr_set()' again, if this is the intention.

lgtm.
send V9 to do this?

>
>>> If you are OK with it, that is good for me too, unless techboard objects
>>> we can proceed with that one.
>>>
>>>