From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 67A7D4CA0; Tue, 30 Oct 2018 11:21:54 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BA8CCC04C267; Tue, 30 Oct 2018 10:21:53 +0000 (UTC) Received: from [10.36.112.50] (ovpn-112-50.ams2.redhat.com [10.36.112.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9C2036091E; Tue, 30 Oct 2018 10:21:51 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Cc: stephen@networkplumber.org, stable@dpdk.org References: <20181029052808.16520-1-tiwei.bie@intel.com> <20181029052808.16520-4-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <8a22482a-ed0b-caed-9877-e54306c9c80e@redhat.com> Date: Tue, 30 Oct 2018 11:21:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181029052808.16520-4-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 30 Oct 2018 10:21:53 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 3/6] net/virtio-user: do not reset owner when driver resets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 10:21:54 -0000 On 10/29/18 6:28 AM, Tiwei Bie wrote: > When driver resets the device, virtio-user just needs to send > GET_VRING_BASE messages to stop the vhost backend, and that's > what QEMU does. With this change, we won't need to set owner > when starting virtio-user device anymore. This will help us to > get rid of below error message on startup: > > vhost_kernel_ioctl(): VHOST_SET_OWNER failed: Device or resource busy > > Fixes: bce7e9050f9b ("net/virtio-user: fix start with kernel vhost") > Fixes: 0d6a8752ac9d ("net/virtio-user: fix crash as features change") > Cc: stable@dpdk.org > > Signed-off-by: Tiwei Bie > --- > .../net/virtio/virtio_user/virtio_user_dev.c | 22 ++++++++++++------- > 1 file changed, 14 insertions(+), 8 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime