From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1C314338E; Tue, 21 Nov 2023 13:39:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B003742EA6; Tue, 21 Nov 2023 13:39:39 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 79FDB42E9D for ; Tue, 21 Nov 2023 13:39:38 +0100 (CET) Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SZP4S305PzsRBL; Tue, 21 Nov 2023 20:36:08 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 21 Nov 2023 20:39:36 +0800 Message-ID: <8a24adb9-008c-41be-1d26-dd4ba3bb1539@huawei.com> Date: Tue, 21 Nov 2023 20:39:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] ethdev: add trace for the new fields added in 23.11 To: Ferruh Yigit CC: , fengchengwen , Thomas Monjalon , Andrew Rybchenko , References: <20231121081801.47098-1-lihuisong@huawei.com> <00ac70e6-24de-4b1f-86a6-051d9a22136c@amd.com> From: "lihuisong (C)" In-Reply-To: <00ac70e6-24de-4b1f-86a6-051d9a22136c@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm000004.china.huawei.com (7.193.23.18) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2023/11/21 20:12, Ferruh Yigit 写道: > On 11/21/2023 8:29 AM, fengchengwen wrote: > >> On 2023/11/21 16:18, Huisong Li wrote: >>> The 'max_rx_bufsize' and 'rss_algo_capa' in struct rte_eth_dev_info and >>> the 'algorithm' in struct rte_eth_rss_conf are introduced to 23.11. >>> This patch add the trace of these new fields in related trace point >>> interface. >>> >>> In addition, the 'max_lro_pkt_size' in struct rte_eth_dev_info is also >>> important. So this patch also add it. >>> >>> Signed-off-by: Huisong Li >> Acked-by: Chengwen Feng >> > Fixes: 75c7849a9dcc ("ethdev: add maximum Rx buffer size") > Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm") > > Reviewed-by: Ferruh Yigit > > > 'max_lro_pkt_size' seems forgotten, and it is not a new field, so patch > adding it should be backported to old releases. > That is why I removed the 'max_lro_pkt_size' from this patch and updated > commit log accordingly, Will send a separate patch for it. Thanks so much for separating this patch for 'max_lro_pkt_size'. 😁 > > > Applied to dpdk-next-net/main, thanks. > .